[FLINK-38531][cdc-connector-mysql]Fix data loss when restoring from a checkpoint positioned in the middle of a bulk DML operation. #4165
+368
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5herhom
force-pushed
the
fix-loss-data
branch
from
1e015c2 to
ca06f6a
Compare
|
Please help review this PR. Thank you. @lvyanquan |
5herhom
force-pushed
the
fix-loss-data
branch
3 times, most recently
from
06a70f4 to
355cfb7
Compare
… checkpoint positioned in the middle of a bulk DML operation.
5herhom
force-pushed
the
fix-loss-data
branch
from
866aff3 to
3764c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail: FLINK-38531
Before fixed, it can not pass the newly added case BinlogOffsetTest#testCompareToWithGtidSetAndSkipEventsAndSkipRows and BinlogSplitReaderTest#testRestoreFromCheckpointWithGtidSetAndSkippingEventsAndRows.
Before fixed, the situation of data loss can be reproduced under the the newly added case BinlogSplitReaderTest#testRestoreFromCheckpointWithGtidSetAndSkippingEventsAndRows.
In addition ,I invert the if-else structure in method BinlogOffset#compareTo to reduce the depth of code blocks and optimize code readability.