[FLINK-38279] Add SnapshotPendingSplitsState to MySQL checkpoint stat… #4127
+115
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice catch! |
Member
|
Hi @dwash96, do you have time to add an E2e test for this change? YamlJobMigrationITCase might be suitable for such a test. Also, please run |
Contributor
Author
|
Oh man, sorry, I will do this by saturday at the latest |
…e restoration [FLINK-38279] This issue currently prevents restoring snapshot jobs from being restart-able from save points/checkpoints which means that large table and database replication must be done in one shot. Any thing that crashes the snapshotting process creates an entirely non-recoverable situation which is highly inconvenient and un-workable in many set ups.
Signed-off-by: yuxiqian <[email protected]>
Member
|
Hi @dwash96 @lvyanquan, I've pushed commits to add corresponding test cases and resolve conflicts. Would you like to take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e restoration
[FLINK-38279]
This issue currently prevents restoring snapshot jobs from being restart-able from save points/checkpoints which means that large table and database replication must be done in one shot. Any thing that crashes the snapshotting process creates an entirely non-recoverable situation which is highly inconvenient and un-workable in many set ups.