[FLINK-37503] Compatibility Issue with MySQL Syntax SHOW MASTER STATUS #3955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
yuxiqian
reviewed
Mar 18, 2025
...or-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java
Outdated
Show resolved
Hide resolved
docs/content.zh/docs/faq/faq.md
Outdated
There was a problem hiding this comment.
MySQL 8.4+ support would be great, but validation is still required. Shall we parameterize MySQL UT & E2e test cases with multiple LTS versions (including 5.7, 8.0, 8.4), just like MongoDB CDC?
joyCurry30
reviewed
Mar 26, 2025
Comment on lines
+140
to
141
| Users can check Binlog_Ignore_DB and Binlog_Do_DB through the `show master status` or `` command | ||
|
|
There was a problem hiding this comment.
Or `` ? There seems to be a lack of concrete content.
joyCurry30
reviewed
Mar 26, 2025
| @@ -62,6 +65,8 @@ public class DebeziumUtils { | |||
|
|
|||
| private static final Logger LOG = LoggerFactory.getLogger(DebeziumUtils.class); | |||
|
|
|||
| private static String showMasterStmt = null; | |||
There was a problem hiding this comment.
Why use 'static String'?Is there a special situation for this use?
|
During the Source initialization, we've included a MySQL version check. Could we leverage this phase to determine which SQL syntax variant to use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FLINK-37503] Compatibility Issue with MySQL Syntax SHOW MASTER STATUS
In newer versions of MySQL, the
SHOW MASTER STATUSsyntax has been deprecated and replaced with show binary log status. Since this syntax is used in MySQL CDC, compatibility adjustments are required.