-
Notifications
You must be signed in to change notification settings - Fork 79
doc : add ElasticsearchVectorStore doc #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@twosom Please add the following content to your PR description and select a checkbox: |
3e293e7 to
27bd922
Compare
|
|
||
| {{< hint info >}} | ||
| Vector stores are currently supported in the Python API only. Java API support is planned for future releases. | ||
| Vector stores are supported in both Python and Java APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just remove this hint?
| List<Document> documents = event.getDocuments(); | ||
| // Process the retrieved documents... | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of this example (i.e., how to search in the vector store with built-in events) is not specific to ES. We may consider modifying the Getting Started section and describe how to do the steps in Java. Then in the Elasticsearch section example, we can keep only the ES specific contents (i.e. creating the resource descriptor). Imagine that in future we may support many vector stores, so it might be better to avoid repeated contents as much as possible. WDYT?
| {{< /tab >}} | ||
|
|
||
| {{< /tabs >}} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also add instructions for building custom vector stores in Java?
Linked issue: #385, #321
Purpose of change
Added documentation for ElasticsearchVectorStore.
Tests
API
Documentation
doc-neededdoc-not-needed