Skip to content

Conversation

@twosom
Copy link
Contributor

@twosom twosom commented Dec 26, 2025

Linked issue: #385, #321

Purpose of change

Added documentation for ElasticsearchVectorStore.

Tests

API

Documentation

  • doc-needed
  • doc-not-needed

@github-actions github-actions bot added priority/major Default priority of the PR or issue. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Dec 26, 2025
@github-actions
Copy link

@twosom Please add the following content to your PR description and select a checkbox:

- [ ] `doc-needed` 
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->

@twosom twosom force-pushed the doc-elasticsearch-vectorstore branch from 3e293e7 to 27bd922 Compare December 26, 2025 03:19
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Dec 26, 2025

{{< hint info >}}
Vector stores are currently supported in the Python API only. Java API support is planned for future releases.
Vector stores are supported in both Python and Java APIs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just remove this hint?

List<Document> documents = event.getDocuments();
// Process the retrieved documents...
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of this example (i.e., how to search in the vector store with built-in events) is not specific to ES. We may consider modifying the Getting Started section and describe how to do the steps in Java. Then in the Elasticsearch section example, we can keep only the ES specific contents (i.e. creating the resource descriptor). Imagine that in future we may support many vector stores, so it might be better to avoid repeated contents as much as possible. WDYT?

{{< /tab >}}

{{< /tabs >}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also add instructions for building custom vector stores in Java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants