[Feature][runtime] Support the use of Java ChatModel in Python #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
priority/major
Collaborator
Author
|
Hi, @Sxnan and @wenjin272. Could you please review this PR? Thank you! |
GreatEugenius
changed the title
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
2 times, most recently
from
b0bdc21 to
2595858
Compare
wenjin272
reviewed
Dec 10, 2025
Collaborator
wenjin272
left a comment
wenjin272
left a comment
There was a problem hiding this comment.
Hi, @GreatEugenius, thanks for your work. Overall looks good to me.
A major comment is could we unify the representation of ResourceProvider in both Python and Java to reduce the complexity for its serialization and deserialization.
runtime/src/main/java/org/apache/flink/agents/runtime/python/utils/JavaResourceAdapter.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/python/utils/JavaResourceAdapter.java
Show resolved
Hide resolved
.../src/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonDeserializer.java
Outdated
Show resolved
Hide resolved
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
from
2595858 to
aa950bd
Compare
Collaborator
Author
|
Hi @wenjin272, I have addressed all the comments and supported ResourceDescriptor serialization and deserialization. Please take a look. |
wenjin272
reviewed
Dec 16, 2025
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
from
eaf807a to
8522ba4
Compare
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
from
8522ba4 to
47d520b
Compare
wenjin272
reviewed
Dec 16, 2025
api/src/main/java/org/apache/flink/agents/api/resource/ResourceDescriptor.java
Show resolved
Hide resolved
api/src/main/java/org/apache/flink/agents/api/resource/ResourceDescriptor.java
Outdated
Show resolved
Hide resolved
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
2 times, most recently
from
65b7451 to
b41aa17
Compare
Collaborator
Author
|
Hi @xintongsong, please take a look at your convenience. |
xintongsong
reviewed
Dec 16, 2025
runtime/src/main/java/org/apache/flink/agents/runtime/python/utils/PythonActionExecutor.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/flink/agents/api/resource/ResourceDescriptor.java
Outdated
Show resolved
Hide resolved
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
from
b41aa17 to
bcf14ff
Compare
Collaborator
Author
|
Hi @xintongsong, I have addressed all the comments. Please take a look. |
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
2 times, most recently
from
41bba58 to
4a214a0
Compare
GreatEugenius
force-pushed
the
java-chatmodel-in-python
branch
from
4a214a0 to
1a848b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #354
Purpose of change
Support the use of the Java ChatModel in Python Flink Agent jobs.
Tests
Unit tests and end-to-end test
API
no
Documentation
doc-neededdoc-not-needed