FINERACT-2624: runreports prepared statement, input validation#5968
Closed
terencemo wants to merge 1 commit into
Closed
FINERACT-2624: runreports prepared statement, input validation#5968terencemo wants to merge 1 commit into
terencemo wants to merge 1 commit into
Conversation
adamsaghy
reviewed
Jun 10, 2026
| synchronized (this) { | ||
| if (databaseProductName == null) { | ||
| try (var connection = jdbcTemplate.getDataSource().getConnection()) { | ||
| databaseProductName = connection.getMetaData().getDatabaseProductName().toLowerCase(); |
Contributor
There was a problem hiding this comment.
Please use the hikari JDBC url from application.properties instead.
its a waste of resource open a connection just for this...
Example: org.apache.fineract.infrastructure.core.domain.FineractPlatformTenantConnection#resolveProtocol
6 tasks
Contributor
Author
|
Closing in favour of #5972 , which implements suggested change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances stretchy reporting in Fineract by:
Integrations tests have been added which invoke
runreportswith both valid and invalid inputs. Numeric parameter (officeId) positive and negative tests (numeric and non-numeric input) - some of the invalid inputs includeSLEEPandpg_sleepcommands. AlsoUNION ALLinputs passed attempting SQL injection.Besides this, unregistered parameter passing is covered where a parameter not in
stretchy_report_parameterfor the given report is passed. Additional integration tests can be added to cover date and string parameter types.This PR adds input validation in
fineract-corewith configurable patterns inapplication.propertiesChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.