Skip to content

FINERACT-2421: Decrease code debt - Part 1#5965

Merged
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2421/decrease-code-debt-1
Jun 10, 2026
Merged

FINERACT-2421: Decrease code debt - Part 1#5965
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2421/decrease-code-debt-1

Conversation

@adamsaghy

Copy link
Copy Markdown
Contributor

Description

  • Turn off processing (global) and options (avro-schemas) linting -> Too much noise, no added value
  • Removed / reworked deprecated methods
  • Reworked casting, better type-safety

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy marked this pull request as draft June 9, 2026 18:52
@adamsaghy adamsaghy force-pushed the FINERACT-2421/decrease-code-debt-1 branch from c222e47 to c7266ff Compare June 9, 2026 19:22
@adamsaghy adamsaghy marked this pull request as ready for review June 9, 2026 22:52

@Aman-Mittal Aman-Mittal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to merge - refactoring is done to improve code quality.

@adamsaghy adamsaghy merged commit 5a81c99 into apache:develop Jun 10, 2026
90 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2421/decrease-code-debt-1 branch June 10, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants