FINERACT-2631: Extend FeignClientHelper with pending client creation, status transitions, and CRUD#5954
Open
DeathGun44 wants to merge 1 commit into
Conversation
budaidev
requested changes
Jun 8, 2026
f8883a7 to
943dddb
Compare
Contributor
Please run: |
667fa95 to
edfd31f
Compare
Contributor
Author
|
@adamsaghy @budaidev rebased and ready for re review! |
… status transitions, and CRUD Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
edfd31f to
e6cc3a3
Compare
Contributor
|
@budaidev Please re-review it. (it is blocked till you rereview it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends FeignClientHelper from 4 to 16 methods and adds ClientRequestBuilders and FeignClientLifecycleTest covering the full client lifecycle - pending creation, activate, close, reject, reactivate, withdraw, undo-reject, undo-withdraw, update, delete, search, and account retrieval.
Depends on: FINERACT-2632
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.