Skip to content

FINERACT-2631: Extend FeignClientHelper with pending client creation, status transitions, and CRUD#5954

Open
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2631/feign-client-helper-and-tests
Open

FINERACT-2631: Extend FeignClientHelper with pending client creation, status transitions, and CRUD#5954
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2631/feign-client-helper-and-tests

Conversation

@DeathGun44

Copy link
Copy Markdown
Contributor

Description

Extends FeignClientHelper from 4 to 16 methods and adds ClientRequestBuilders and FeignClientLifecycleTest covering the full client lifecycle - pending creation, activate, close, reject, reactivate, withdraw, undo-reject, undo-withdraw, update, delete, search, and account retrieval.

Depends on: FINERACT-2632

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@DeathGun44 DeathGun44 force-pushed the FINERACT-2631/feign-client-helper-and-tests branch 2 times, most recently from f8883a7 to 943dddb Compare June 8, 2026 12:49
@adamsaghy

Copy link
Copy Markdown
Contributor
                                                                     ^
/home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/ClientRequestBuilders.java:38: error: cannot find symbol
                .submittedOnDate(submittedOnDate)//
                ^
  symbol:   method submittedOnDate(String)
  location: class PostClientsRequest
/home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/ClientRequestBuilders.java:77: error: cannot find symbol
                .withdrawalReasonId(withdrawalReasonId)//
                ^
  symbol:   method withdrawalReasonId(Long)
  location: class PostClientsClientIdRequest
/home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/ClientRequestBuilders.java:85: error: cannot find symbol
                .reopenedDate(reopenedDate);
                ^
  symbol:   method reopenedDate(String)
  location: class PostClientsClientIdRequest
/home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/ClientRequestBuilders.java:92: error: cannot find symbol
                .reopenedDate(reopenedDate);
                ^
  symbol:   method reopenedDate(String)
  location: class PostClientsClientIdRequest
/home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/ClientRequestBuilders.java:97: error: cannot find symbol
                .firstname(firstname)//
                ^

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

@DeathGun44 DeathGun44 force-pushed the FINERACT-2631/feign-client-helper-and-tests branch 2 times, most recently from 667fa95 to edfd31f Compare June 8, 2026 17:34
@DeathGun44

Copy link
Copy Markdown
Contributor Author

@adamsaghy @budaidev rebased and ready for re review!

… status transitions, and CRUD

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
@DeathGun44 DeathGun44 force-pushed the FINERACT-2631/feign-client-helper-and-tests branch from edfd31f to e6cc3a3 Compare June 8, 2026 18:04

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy requested a review from budaidev June 8, 2026 19:33
@adamsaghy

Copy link
Copy Markdown
Contributor

@budaidev Please re-review it. (it is blocked till you rereview it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants