FINERACT-2616: OIDC Federation support for IdP#5883
Conversation
b3c6437 to
355873c
Compare
|
@alberto-art3ch Please review the failing quality checks. |
f8321c2 to
871708a
Compare
d0b23dc to
950acfa
Compare
950acfa to
ea2c226
Compare
galovics
left a comment
There was a problem hiding this comment.
All four review comments from my previous pass have been addressed:
- Spring @transactional is used instead of Jakarta
- provider is modeled as OidcFederationType enum
- catch block in OidcTenantAwareFilter now logs a warning
- The hardcoded 1L for head office is replaced with a configurable fineractProperties.getDefaults().getOfficeId()
The mailing list requirement (per-tenant OIDC configuration, different IdP per tenant) has also been implemented - the m_tenant_oidc_config table, TenantOidcConfigApiResource, and DynamicJwtIssuerAuthenticationManagerResolver address exactly what I asked for on the thread.
Build quality checks still need to be green before merge.
ea2c226 to
9f38acb
Compare
9f38acb to
719c5db
Compare
@galovics |
|
@IOhacker Kindly asking you to update your review |
Description
We are adding a complete OIDC (OpenID Connect) Federation layer for Apache Fineract, enabling integration with external Identity Providers (Keycloak, Google, Azure AD, Okta, Auth0) without replacing the existing Basic Auth mechanism.
fineract.security.oidc-federation.enabled=truefineract.security.oidc-federationFINERACT-2616
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.