FINERACT-2566: Refresh loan summary after account-transfer disbursement charge collection#5710
Open
rhopman wants to merge 2 commits intoapache:developfrom
Open
FINERACT-2566: Refresh loan summary after account-transfer disbursement charge collection#5710rhopman wants to merge 2 commits intoapache:developfrom
rhopman wants to merge 2 commits intoapache:developfrom
Conversation
…nt charge collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a loan is disbursed and one or more loan charges have their payment mode set to Account Transfer (
ACCOUNT_TRANSFER), the system collects each charge by callingtransferFunds() on the linked savings account. This creates aREPAYMENT_AT_DISBURSEMENTloan transaction and marks the charge as paid.However,
transferFunds()does not recompute theLoanSummaryderived fields. As a result, fields such asfeeChargesPaid,feeChargesOutstanding, andtotalOutstandingremain stale, reflecting the values computed during thesaveAndFlushthat preceded the charge loop.This causes the loan balance to appear higher than what the client actually owes after disbursement.
Fix
After the
disBuLoanChargestransfer loop, when the map is non-empty, call:Checklist