FINERACT-5706: Add unit tests for IpAddressUtils#5706
Open
shleshaG wants to merge 1 commit intoapache:developfrom
Open
FINERACT-5706: Add unit tests for IpAddressUtils#5706shleshaG wants to merge 1 commit intoapache:developfrom
shleshaG wants to merge 1 commit intoapache:developfrom
Conversation
|
@shleshaG Could you please update the PR title and commit message to follow our naming convention: |
shleshaG
changed the title
shleshaG
force-pushed
the
ipaddressutils-tests
branch
from
8e9e189 to
5fa8955
Compare
Author
|
@San-43 Updated commit message and signed the commit as requested. Thanks! |
shleshaG
force-pushed
the
ipaddressutils-tests
branch
3 times, most recently
from
4e57a8d to
4791351
Compare
Aman-Mittal
reviewed
Mar 28, 2026
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the |
Contributor
There was a problem hiding this comment.
Do not remove licence header
Aman-Mittal
reviewed
Mar 28, 2026
| testLogic.run(); | ||
| } finally { | ||
| RequestContextHolder.resetRequestAttributes(); // critical cleanup | ||
| RequestContextHolder.resetRequestAttributes(); |
Contributor
There was a problem hiding this comment.
It Doesnt do anything. Better to revert this file change entirely
shleshaG
force-pushed
the
ipaddressutils-tests
branch
7 times, most recently
from
ea5ffc2 to
b31e66f
Compare
Signed-off-by: Shlesha <shlesha04@gmail.com>
shleshaG
force-pushed
the
ipaddressutils-tests
branch
from
b31e66f to
7d94545
Compare
Author
|
@Aman-Mittal Reverted unintended changes to MathUtilTest. Now the PR only includes IpAddressUtils tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added unit tests for IpAddressUtils.
Covered scenarios:
All tests pass successfully.
Checklist