Skip to content

FINERACT-2571: Migrate charge creation helper to feign client#5703

Open
lliikkii7722-ops wants to merge 1 commit intoapache:developfrom
lliikkii7722-ops:fix-deprecated-charges
Open

FINERACT-2571: Migrate charge creation helper to feign client#5703
lliikkii7722-ops wants to merge 1 commit intoapache:developfrom
lliikkii7722-ops:fix-deprecated-charges

Conversation

@lliikkii7722-ops
Copy link
Copy Markdown

This change migrates a deprecated helper method in ChargesHelper from RestAssured (Utils.performServerPost) to the feign client approach using FineractClientHelper.

This aligns with the ongoing effort to modernize integration tests and reduce direct HTTP usage.

Only a single method is migrated in this PR to keep the change minimal and review-friendly.

@IOhacker
Copy link
Copy Markdown
Contributor

@lliikkii7722-ops please have a conversation about the ticket in the Apache Fineract dev list and make sure to include a Jira ticket in the Commit description and PR Title. Also make sure to review the developer convention.

@lliikkii7722-ops
Copy link
Copy Markdown
Author

@lliikkii7722-ops please have a conversation about the ticket in the Apache Fineract dev list and make sure to include a Jira ticket in the Commit description and PR Title. Also make sure to review the developer convention.

Thank you for the guidance.

I understand that a Jira ticket and mailing list discussion are required.
I will initiate a discussion on the Apache Fineract dev mailing list for this change.

Please let me know if I should wait for discussion approval before updating the PR.

Thank you.

@lliikkii7722-ops lliikkii7722-ops changed the title Migrate charge creation helper to feign client FINERACT-2571: Migrate charge creation helper to feign client Mar 30, 2026
@lliikkii7722-ops
Copy link
Copy Markdown
Author

@lliikkii7722-ops please have a conversation about the ticket in the Apache Fineract dev list and make sure to include a Jira ticket in the Commit description and PR Title. Also make sure to review the developer convention.

Thank you for the guidance.

I have created the Jira ticket FINERACT-2571 and updated the PR title and commit message accordingly.

I will initiate a discussion on the Apache Fineract dev mailing list for this change.

Please let me know if I should wait for mailing list discussion approval before further updates.

Thank you.

@lliikkii7722-ops lliikkii7722-ops force-pushed the fix-deprecated-charges branch 3 times, most recently from 894030e to 95b4666 Compare March 30, 2026 15:38
@Aman-Mittal
Copy link
Copy Markdown
Contributor

@lliikkii7722-ops Please sign your commits

i
FINERACT-2571: Migrate charge creation helper to feign client

Migrate charge creation helper to feign client

FINERACT-2571: Migrate charge creation helper to feign client
@lliikkii7722-ops
Copy link
Copy Markdown
Author

@lliikkii7722-ops Please sign your commits

i will do thankyou !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants