Skip to content

Conversation

@mariiaKraievska
Copy link
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2412/full-term-tranche-schedule-handling-and-calculation branch 2 times, most recently from ff77199 to ee3752c Compare January 7, 2026 14:21
@adamsaghy adamsaghy force-pushed the FINERACT-2412/full-term-tranche-schedule-handling-and-calculation branch from ee3752c to 926421f Compare January 8, 2026 14:06
@adamsaghy adamsaghy marked this pull request as ready for review January 8, 2026 17:37
final LocalDate firstDisbursedPeriodStartDate = firstDisbursedPeriod.isPresent() ? firstDisbursedPeriod.get().getFromDate()
: scheduleModel.getMaturityDate();

final LoanApplicationTerms loanApplicationTerms = new LoanApplicationTerms.Builder()
Copy link
Contributor

@Aman-Mittal Aman-Mittal Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LoanAplicationBuilder Logic must be extracted to an new helper function. So that it is easier to read.

and group this chaining maybe like this?

// Loan basics
.currency(...)
.principal(...)
.repaymentsStartingFromDate(...)

// Term & frequency
.loanTermFrequency(...)
.numberOfRepayments(...)
.repaymentEvery(...)
.repaymentPeriodFrequencyType(...)

// Interest configuration
.interestRatePerPeriod(...)
.annualNominalInterestRate(...)
.interestRatePeriodFrequencyType(...)
.interestMethod(...)

// Day count conventions
.daysInMonthType(...)
.daysInYearType(...)
.daysInYearCustomStrategy(...)

// Flags & options
.isDownPaymentEnabled(false)
.allowPartialPeriodInterestCalculation(...)

// Technical
.mc(mc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2412/full-term-tranche-schedule-handling-and-calculation branch from 926421f to cdaf5bc Compare January 9, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants