Skip to content

Conversation

@airajena
Copy link
Contributor

@airajena airajena commented Jan 3, 2026

Description

Fixes typo in ConditionType enum: GRETERTHANGREATERTHAN
This addresses the TODO comment at line 28 of ConditionType.java.

Changes

  • ConditionType.java - Fixed enum name and code string
  • CommonEnumerations.java - Updated switch case references
  • DropdownReadPlatformServiceImpl.java - Updated enum reference
  • AttributeIncentiveCalculation.java - Updated switch case

Related Issue

FINERACT-2421

Copy link
Contributor

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and as for the the failing GA, i think it will get passed when this branch gets rebased with the upstream develop branch.

@adamsaghy
Copy link
Contributor

Test testPostInterestNotZero() FAILED (2.2s)
  
    java.lang.AssertionError: 1 expectation failed.
    Expected status code <200> but was <400>.
        at org.apache.fineract.integrationtests.SavingsInterestPostingTest.lambda$testPostInterestNotZero$4(SavingsInterestPostingTest.java:346)
  
  

@airajena airajena force-pushed the FINERACT-2421/fix-conditiontype-typo branch from cf11acf to 01073ff Compare January 9, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants