-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataZoom): new option handleLabelShow #20082
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20082@dd5d624 |
@@ -79,6 +79,8 @@ export interface SliderDataZoomOption extends DataZoomOption, BoxLayoutOptionMix | |||
|
|||
handleIcon?: string | |||
|
|||
handleLabelShow?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just be curious about the position of Show
.
@@ -171,6 +174,7 @@ class SliderZoomModel extends DataZoomModel<SliderDataZoomOption> { | |||
// Color of selected window. | |||
fillerColor: 'rgba(135,175,274,0.2)', | |||
handleIcon: 'path://M-9.35,34.56V42m0-40V9.5m-2,0h4a2,2,0,0,1,2,2v21a2,2,0,0,1-2,2h-4a2,2,0,0,1-2-2v-21A2,2,0,0,1-11.35,9.5Z', | |||
handleLabelShow: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be commented on if it's not enabled by default.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR provides a new option
dataZoom(slider).handleLabelShow
anddataZoom(slider).emphasis.handleLabelShow
to control when to show the handle labels.Fixed issues
#19676
Details
Before: What was the problem?
Handle labels are shown when mouse hovering or dragging. But there is no way to always show the labels, or always hide the labels.
After: How does it behave after the fixing?
With
dataZoom(slider).handleLabelShow
anddataZoom(slider).emphasis.handleLabelShow
, developers can now decide when to show the labels.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information