Skip to content

test: add unit test for multiple clients watching same service in Tri Health#16326

Open
LI123456mo wants to merge 2 commits into
apache:3.3from
LI123456mo:test-triple-health-multiple-watchers
Open

test: add unit test for multiple clients watching same service in Tri Health#16326
LI123456mo wants to merge 2 commits into
apache:3.3from
LI123456mo:test-triple-health-multiple-watchers

Conversation

@LI123456mo

Copy link
Copy Markdown
Contributor

What is the purpose of the change?

This pull request introduces a new unit test testMultipleClientsWatchingSameService to TriHealthImplTest. The purpose is to verify that the Triple health check implementation correctly notifies multiple stream observers (StreamObserver) when they are simultaneously watching the same service and a status change occurs.

Brief Changelog

  • TriHealthImplTest.java: Added testMultipleClientsWatchingSameService() unit test verifying multi-client subscription updates.

Verifying this change

This change is a pure test enhancement. You can verify it runs and passes successfully by running:

mvn test -pl dubbo-rpc/dubbo-rpc-triple -Dtest=TriHealthImplTest

@LI123456mo LI123456mo force-pushed the test-triple-health-multiple-watchers branch from 7d17191 to 6fb3daf Compare June 9, 2026 06:01
@LI123456mo LI123456mo force-pushed the test-triple-health-multiple-watchers branch from 6fb3daf to 16ad62c Compare June 9, 2026 06:22
@codecov-commenter

codecov-commenter commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.80%. Comparing base (c3ceb27) to head (2d487dd).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16326      +/-   ##
============================================
+ Coverage     60.79%   60.80%   +0.01%     
+ Complexity    11777    11765      -12     
============================================
  Files          1953     1953              
  Lines         89208    89208              
  Branches      13458    13458              
============================================
+ Hits          54234    54243       +9     
+ Misses        29403    29396       -7     
+ Partials       5571     5569       -2     
Flag Coverage Δ
integration-tests-java21 32.11% <ø> (-0.01%) ⬇️
integration-tests-java8 32.24% <ø> (-0.08%) ⬇️
samples-tests-java21 32.18% <ø> (+0.05%) ⬆️
samples-tests-java8 29.78% <ø> (-0.09%) ⬇️
unit-tests-java11 59.03% <ø> (+<0.01%) ⬆️
unit-tests-java17 58.52% <ø> (+<0.01%) ⬆️
unit-tests-java21 58.51% <ø> (+<0.01%) ⬆️
unit-tests-java25 58.47% <ø> (-0.01%) ⬇️
unit-tests-java8 59.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw changed the title test: add unit test for multiple clients watching same service in Tri… test: add unit test for multiple clients watching same service in Tri Health Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants