Fix Triple method resolution for overloaded wrapper methods#16325
Open
skt-shinyruo wants to merge 1 commit into
Open
Fix Triple method resolution for overloaded wrapper methods#16325skt-shinyruo wants to merge 1 commit into
skt-shinyruo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16325 +/- ##
============================================
+ Coverage 58.80% 60.78% +1.98%
Complexity 15 15
============================================
Files 1953 1953
Lines 89208 89254 +46
Branches 13458 13470 +12
============================================
+ Hits 52458 54257 +1799
+ Misses 31073 29422 -1651
+ Partials 5677 5575 -102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes apache#14939 Signed-off-by: bubu <1654388696@qq.com>
71d92a2 to
bc8d337
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14939
Verification
mvn -pl dubbo-rpc/dubbo-rpc-triple -Dtest=DescriptorUtilsTest,ReflectionPackableMethodTest testmvn test -Djdk.net.hosts.file=/tmp/dubbo-test-hostsreacheddubbo-metrics-registryand failed there inRegistryMetricsTest.testAvgResponseTimewith an assertion mismatch unrelated to this patch.