Skip to content

Fix Triple method resolution for overloaded wrapper methods#16325

Open
skt-shinyruo wants to merge 1 commit into
apache:3.3from
skt-shinyruo:repro-14939-triple-overload
Open

Fix Triple method resolution for overloaded wrapper methods#16325
skt-shinyruo wants to merge 1 commit into
apache:3.3from
skt-shinyruo:repro-14939-triple-overload

Conversation

@skt-shinyruo

Copy link
Copy Markdown
Contributor

Summary

  • Prefer exact Triple wrapper arg-type matching when resolving overloaded methods.
  • Only fall back to the generated unary/server-stream pair when the pair is verified.
  • Fail fast on ambiguous overloads instead of guessing.

Fixes #14939

Verification

  • mvn -pl dubbo-rpc/dubbo-rpc-triple -Dtest=DescriptorUtilsTest,ReflectionPackableMethodTest test
  • Full mvn test -Djdk.net.hosts.file=/tmp/dubbo-test-hosts reached dubbo-metrics-registry and failed there in RegistryMetricsTest.testAvgResponseTime with an assertion mismatch unrelated to this patch.

@codecov-commenter

codecov-commenter commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.35294% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.78%. Comparing base (d535eac) to head (bc8d337).
⚠️ Report is 3 commits behind head on 3.3.

Files with missing lines Patch % Lines
...apache/dubbo/rpc/protocol/tri/DescriptorUtils.java 57.35% 17 Missing and 12 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16325      +/-   ##
============================================
+ Coverage     58.80%   60.78%   +1.98%     
  Complexity       15       15              
============================================
  Files          1953     1953              
  Lines         89208    89254      +46     
  Branches      13458    13470      +12     
============================================
+ Hits          52458    54257    +1799     
+ Misses        31073    29422    -1651     
+ Partials       5677     5575     -102     
Flag Coverage Δ
integration-tests-java21 32.09% <2.94%> (?)
integration-tests-java8 32.21% <2.94%> (?)
samples-tests-java21 32.17% <0.00%> (?)
samples-tests-java8 29.74% <0.00%> (?)
unit-tests-java11 59.04% <57.35%> (-0.01%) ⬇️
unit-tests-java17 58.53% <57.35%> (+<0.01%) ⬆️
unit-tests-java21 58.54% <57.35%> (+0.02%) ⬆️
unit-tests-java25 58.47% <57.35%> (+0.04%) ⬆️
unit-tests-java8 59.07% <57.35%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fixes apache#14939

Signed-off-by: bubu <1654388696@qq.com>
@skt-shinyruo skt-shinyruo force-pushed the repro-14939-triple-overload branch from 71d92a2 to bc8d337 Compare June 9, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dubbo 3.3.2 stream error because there are same method names in one class

2 participants