Fix Empty return type in triple generator#16324
Open
gaoxiaolei-s59 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16324 +/- ##
============================================
+ Coverage 60.79% 60.97% +0.18%
+ Complexity 11777 11773 -4
============================================
Files 1953 1953
Lines 89208 89217 +9
Branches 13458 13460 +2
============================================
+ Hits 54234 54401 +167
+ Misses 29403 29218 -185
- Partials 5571 5598 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dc45bda to
f5889a1
Compare
Contributor
|
@heliang666s PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix the Dubbo3 Triple generator output for unary methods whose response type is
google.protobuf.Empty. The generated synchronous Java method now usesvoid, while descriptor, parser, async, and StreamObserver paths keep usingcom.google.protobuf.Empty.Fixes #15629
Brief changelog
google.protobuf.Emptytocom.google.protobuf.Emptyin generator type context.Verifying this change
./mvnw -pl dubbo-plugin/dubbo-compiler test