Improve AddressMatch CIDR naming compatibility#16315
Open
yin-bo-Final wants to merge 5 commits into
Open
Conversation
Add cidr accessors while keeping deprecated cird accessors for backward compatibility. Add tests for cidr and cird field mapping through PojoUtils. Refs apache#16314
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16315 +/- ##
============================================
+ Coverage 58.80% 60.80% +2.00%
- Complexity 15 11769 +11754
============================================
Files 1953 1953
Lines 89208 89213 +5
Branches 13458 13458
============================================
+ Hits 52458 54246 +1788
+ Misses 31073 29396 -1677
+ Partials 5677 5571 -106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR improves the CIDR naming in
AddressMatchwhile keeping backward compatibility.cidrfield andgetCidr/setCidraccessors.cirdfield andgetCird/setCirdaccessors as deprecated for compatibility.getCidr().cidrand deprecatedcirdfield mapping throughPojoUtils.cirdtypo inNetUtilsJavadoc.Motivation
cirdappears to be a typo ofcidr, where CIDR stands for Classless Inter-Domain Routing. Since the old name may already be used by configuration binding or external code, this PR keeps backward compatibility while introducing the correct naming.Closes #16314
Tests
./mvnw -pl dubbo-cluster -Dtest=AddressMatchTest test