WebSocket on Triple #14390
Merged
WebSocket on Triple #14390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finefuture
force-pushed
the
3.3-websocket-support
branch
8 times, most recently
from
f55b4a2
to
67d15ef
Compare
|
finefuture
force-pushed
the
3.3-websocket-support
branch
from
67d15ef
to
5f30fcf
Compare
finefuture
force-pushed
the
3.3-websocket-support
branch
from
5f30fcf
to
0252ed7
Compare
|
Hold, this also requires adding triple client. |
# Conflicts: # dubbo-demo/dubbo-demo-spring-boot/dubbo-demo-spring-boot-provider/src/main/resources/application.yml # dubbo-dependencies-bom/pom.xml # dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/AbstractServerHttpChannelObserver.java # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java
|
oxsean
reviewed
Aug 28, 2024
...t/src/main/java/org/apache/dubbo/rpc/protocol/tri/javax/websocket/TripleWebSocketFilter.java
Outdated
Show resolved
Hide resolved
oxsean
reviewed
Aug 28, 2024
...e/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTripleAutoConfiguration.java
Outdated
Show resolved
Hide resolved
# Conflicts: # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java # dubbo-spring-boot/dubbo-spring-boot-3-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTriple3AutoConfiguration.java # dubbo-spring-boot/dubbo-spring-boot-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTripleAutoConfiguration.java
Fix issues
# Conflicts: # dubbo-distribution/dubbo-all-shaded/pom.xml # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleConstants.java # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java
Open
4 tasks
# Conflicts: # dubbo-spring-boot-project/dubbo-spring-boot-3-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTriple3AutoConfiguration.java # dubbo-spring-boot-project/dubbo-spring-boot-autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboTripleAutoConfiguration.java
oxsean
approved these changes
Nov 5, 2024
| @@ -103,6 +103,8 @@ public interface Constants { | |||
|
|
|||
| String HTTP3_KEY = "http3"; | |||
|
|
|||
| String TRIPLE_SERVLET_KEY = "triple.servlet"; | |||
There was a problem hiding this comment.
Mark, it will be fixed in next pr.
EarthChen
approved these changes
Nov 13, 2024
| } | ||
|
|
||
| @Override | ||
| protected void doOnError(Throwable throwable) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Refer: #14298
Brief changelog
Verifying this change
Checklist