Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail #2685

Merged

Conversation

YarBor
Copy link
Contributor

@YarBor YarBor commented Jun 4, 2024

to support #2684

#2686

YarBor added 5 commits June 3, 2024 15:13
Signed-off-by: YarBor <[email protected]>
…nd multiConditionRoute, rewrite some logic, add version check in gen conditionRoute, add version check func in cluster/router/utils

Signed-off-by: YarBor <[email protected]>
Signed-off-by: YarBor <[email protected]>
@YarBor YarBor changed the title support condition rule multiply destination support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail Jun 4, 2024
@@ -18,6 +18,10 @@
package condition

import (
"dubbo.apache.org/dubbo-go/v3/cluster/utils"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format 下 import 的整体内容

Signed-off-by: YarBor <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 61.73913% with 44 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (2f5143a) to head (da47ad5).
Report is 20 commits behind head on main.

Current head da47ad5 differs from pull request most recent head b93ca07

Please upload reports for the commit b93ca07 to get more accurate results.

Files Patch % Lines
cluster/router/condition/dynamic_router.go 58.06% 25 Missing and 14 partials ⚠️
cluster/router/condition/route.go 77.27% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   47.38%   47.18%   -0.20%     
==========================================
  Files         341      343       +2     
  Lines       25122    25403     +281     
==========================================
+ Hits        11904    11987      +83     
- Misses      12074    12248     +174     
- Partials     1144     1168      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

)

import (
"dubbo.apache.org/dubbo-go/v3/cluster/utils"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit d7ce4d4 into apache:main Jun 6, 2024
5 checks passed
@YarBor
Copy link
Contributor Author

YarBor commented Jun 11, 2024

#2686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants