feat: Add category dimension to task running count and new task slot metrics#19554
Draft
benhopp wants to merge 1 commit into
Draft
feat: Add category dimension to task running count and new task slot metrics#19554benhopp wants to merge 1 commit into
benhopp wants to merge 1 commit into
Conversation
…metrics This patch introduces the "category" dimension to the "task/running/count" metric in the prometheus-emitter to provide better visibility into task distribution across different worker categories (tiers). Additionally, it adds new task slot metrics dimensionalized by category: - taskSlot/total/count - taskSlot/idle/count - taskSlot/used/count - taskSlot/lazy/count - taskSlot/blacklisted/count To support this, new infrastructure is added: 1) A new `getRunningTaskCountByCategory()` method in `TaskCountStatsProvider`, `TaskMaster`, and `TaskQueue` to group the running tasks. 2) A new `getRunningTasksByCategory()` method in `TaskRunner` which is implemented by `HttpRemoteTaskRunner` to gather task runner work items by their worker's category.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the "category" dimension to the "task/running/count" metric in the prometheus-emitter to provide better visibility into task distribution across different worker categories (tiers).
Additionally, it adds new task slot metrics dimensionalized by category:
To support this, new infrastructure is added:
getRunningTaskCountByCategory()method inTaskCountStatsProvider,TaskMaster, andTaskQueueto group the running tasks.getRunningTasksByCategory()method inTaskRunnerwhich is implemented byHttpRemoteTaskRunnerto gather task runner work items by their worker's category.