Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-7165: Redundant Checksum calculating for ASC files #1743

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

vdiravka
Copy link
Member

@vdiravka vdiravka commented Apr 10, 2019

  • change 'checksum-maven-plugin' 'goal' - 'artifacts' -> 'files'
  • specify 'includes' in 'fileSet' for 'checksum-maven-plugin'

@vdiravka vdiravka requested a review from sohami April 10, 2019 21:16
@vdiravka
Copy link
Member Author

@sohami Couold you please review?
Here is one not mandatory change: drill-root -> apache-drill project artifactId.
It is more convenient to use it as a parameter ${project.artifactId} or ${project.parent.artifactId} instead of hardcoding apache-drill everywhere.
The question is it safe to change Drill project artifactId? Looks like drill-root isn't used by external tools.
Not sure there are other risks to rename it. If they are, please let me know.

@sohami
Copy link
Contributor

sohami commented Apr 10, 2019

@vdiravka - I would recommend handling the rename change in separate PR rather than doing now if there is even slight risk of it breaking anything.

- change 'checksum-maven-plugin' 'goal' - 'artifacts' -> 'files'
- specify 'includes' in 'fileSet' for 'checksum-maven-plugin'
@vdiravka
Copy link
Member Author

@sohami PR for project root POM ArtifactId rename is created: #1746

Copy link
Contributor

@sohami sohami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@sohami sohami merged commit 494c206 into apache:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants