Skip to content

[fix](regression) Fix agg_sync_mv data path#65538

Draft
shuke987 wants to merge 1 commit into
apache:masterfrom
shuke987:agent/fix-agg-sync-mv-data-path
Draft

[fix](regression) Fix agg_sync_mv data path#65538
shuke987 wants to merge 1 commit into
apache:masterfrom
shuke987:agent/fix-agg-sync-mv-data-path

Conversation

@shuke987

@shuke987 shuke987 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: N/A

Related PR: #65133, #65336

Problem Summary:

The second streamLoad in nereids_syntax_p1/mv/aggregate/agg_sync_mv.groovy still uses the database and data-file path from before the case was moved into the aggregate directory.

The stale ../agg_mv_test.dat path does not exist. The stream load therefore returns no response, and the regression framework later reports the misleading Text must not be null or empty error while parsing it.

Align the second load with the working initial load by using database regression_test_nereids_syntax_p1_mv_aggregate and file agg_mv_test.dat.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason: test-only path correction; git diff --check passes, the corrected data file exists, and the stale parent path does not.
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987

Copy link
Copy Markdown
Collaborator Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #65538. I did not find a reportable issue.

Checkpoint conclusions:

  • Goal/test proof: The patch fixes the second stream load in agg_sync_mv.groovy so it uses the p1 aggregate suite database and the aggregate data file path. Static framework inspection shows those are the correct targets.
  • Scope/focusedness: The change is narrowly limited to the broken regression suite stream-load target.
  • Concurrency/lifecycle/config/persistence/protocol: Not applicable; this is a test-only path change.
  • Parallel paths: The p0 aggregate suite intentionally uses a different parent data-file/database layout; the p1 nested aggregate suite should use regression_test_nereids_syntax_p1_mv_aggregate and local agg_mv_test.dat.
  • Test coverage/results: Existing .out coverage includes the final map_agg block, and the data has no conflicting duplicate key/value pairs after the second load and repeated self-inserts. I did not run the regression test because the review prompt forbids builds/test execution in this runner.
  • User focus: No additional user-provided review focus.

@shuke987

Copy link
Copy Markdown
Collaborator Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants