branch-4.0: [fix](regression) Wait for stable colocate groups in plan tests #64361#64382
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](regression) Wait for stable colocate groups in plan tests #64361#64382github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Problem Summary: Colocate join plan assertions may run before `ColocateTableCheckerAndBalancer` marks the colocate group stable. In that state, Nereids can omit `COLOCATE` from the plan and make otherwise correct regression cases fail intermittently. This PR adds a shared `waitForColocateGroupStable` helper to the regression test framework. It polls `SHOW PROC '/colocation_group'` until the target group's `IsStable` value is true, and fails on timeout. All positive `COLOCATE` plan assertions backed by explicit `colocate_with` groups now wait for stability first. The existing backup/restore-local waiting closure is replaced with the shared helper.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64361