branch-4.0: [fix](fe) Reject TopN in correlated scalar subquery #64251#64350
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](fe) Reject TopN in correlated scalar subquery #64251#64350github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve? Related PR: #39471 Problem Summary: Correlated scalar subqueries with `ORDER BY ... LIMIT 1` were treated like plain `LIMIT 1` subqueries. Analysis eliminated the root `LogicalLimit`, which also discarded the TopN semantics instead of rejecting this unsupported correlated-subquery shape. This change only eliminates a correlated scalar subquery's `LIMIT 1` when the limit does not wrap a `LogicalSort`. A TopN remains in the analyzed plan and is rejected by the existing correlated-subquery validation. FE unit and regression tests verify that `ORDER BY ... LIMIT 1` is rejected, while the existing plain `LIMIT 1` coverage continues to verify the supported path. ### Release note Reject correlated scalar subqueries containing `ORDER BY` with `LIMIT 1`.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64251