Skip to content

[fix](fe) Reject multi-column NGRAM_BF indexes #64343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airborne12 wants to merge 1 commit into
base: master
Choose a base branch
from
+47 −1
Open

[fix](fe) Reject multi-column NGRAM_BF indexes #64343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ore/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/IndexDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,8 @@ public void validate() {
AnnIndexPropertiesChecker.checkProperties(this.properties);
}

if (indexType == IndexType.BITMAP || indexType == IndexType.INVERTED) {
if (indexType == IndexType.BITMAP || indexType == IndexType.INVERTED
|| indexType == IndexType.NGRAM_BF) {
if (cols == null || cols.size() != 1) {
throw new AnalysisException(
indexType.toString() + " index can only apply to a single column.");
Expand Down
8 changes: 8 additions & 0 deletions ...core/src/test/java/org/apache/doris/nereids/trees/plans/commands/IndexDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ void testNgramBFIndex() throws AnalysisException {
KeysType.DUP_KEYS, false, null);
}

@Test
void testNgramBFIndexOnlySingleColumn() {
IndexDefinition def = new IndexDefinition("ngram_bf_index", false, Lists.newArrayList("col1", "col2"),
"NGRAM_BF", null, "comment");
AnalysisException exception = Assertions.assertThrows(AnalysisException.class, def::validate);
Assertions.assertEquals("NGRAM_BF index can only apply to a single column.", exception.getMessage());
}

@Test
void testInvalidNgramBFIndexColumnType() {
Map<String, String> properties = new HashMap<>();
Expand Down
37 changes: 37 additions & 0 deletions regression-test/suites/index_p0/test_ngram_bloomfilter_index.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,41 @@ suite("test_ngram_bloomfilter_index") {
sql """ALTER TABLE ${tableName3} ADD INDEX idx_http_url(http_url) USING NGRAM_BF PROPERTIES("gram_size"="256", "bf_size"="65535") COMMENT 'http_url ngram_bf index'"""
exception "java.sql.SQLException: errCode = 2, detailMessage = 'gram_size' should be an integer between 1 and 255."
}

sql "DROP TABLE IF EXISTS test_ngram_bloomfilter_multi_column_index"
test {
sql """
CREATE TABLE test_ngram_bloomfilter_multi_column_index (
`key_id` bigint(20) NULL COMMENT '',
`http_url` text NULL COMMENT '',
`url_path` varchar(2000) NULL COMMENT '',
INDEX idx_ngrambf_multi (`http_url`, `url_path`) USING NGRAM_BF
PROPERTIES("gram_size" = "2", "bf_size" = "512")
) ENGINE=OLAP
DUPLICATE KEY(`key_id`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`key_id`) BUCKETS 1
PROPERTIES("replication_num" = "1");
"""
exception "NGRAM_BF index can only apply to a single column."
}

sql """
CREATE TABLE test_ngram_bloomfilter_multi_column_index (
`key_id` bigint(20) NULL COMMENT '',
`http_url` text NULL COMMENT '',
`url_path` varchar(2000) NULL COMMENT ''
) ENGINE=OLAP
DUPLICATE KEY(`key_id`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`key_id`) BUCKETS 1
PROPERTIES("replication_num" = "1");
"""
test {
sql """
CREATE INDEX idx_ngrambf_multi ON test_ngram_bloomfilter_multi_column_index(`http_url`, `url_path`)
USING NGRAM_BF PROPERTIES("gram_size" = "2", "bf_size" = "512")
"""
exception "NGRAM_BF index can only apply to a single column."
}
}
Loading