Skip to content

branch-4.1:[fix](iceberg)fix iceberg write special partition error. (#64225)#64339

Open
hubgeter wants to merge 1 commit into
apache:masterfrom
hubgeter:pick_ms_iceberg_sepcial_path
Open

branch-4.1:[fix](iceberg)fix iceberg write special partition error. (#64225)#64339
hubgeter wants to merge 1 commit into
apache:masterfrom
hubgeter:pick_ms_iceberg_sepcial_path

Conversation

@hubgeter

@hubgeter hubgeter commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:

  • This is a refactor/code format and no logic has been changed.
    - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.

  • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hubgeter
branch-4.1:[fix](iceberg)fix iceberg write special partition error. (a…
f16e401 
…pache#64225)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@hello-stephen

hello-stephen commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter

hubgeter commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28656 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f16e401af2aad0528e843109004f8e82209317a5, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17687	3978	3970	3970
q2	q3	10809	1352	827	827
q4	4686	480	342	342
q5	7555	900	576	576
q6	181	179	158	158
q7	801	825	651	651
q8	9888	1664	1638	1638
q9	6692	4459	4514	4459
q10	6786	1825	1499	1499
q11	431	274	246	246
q12	651	434	294	294
q13	18165	3402	2738	2738
q14	268	257	243	243
q15	q16	827	773	705	705
q17	1009	1003	923	923
q18	6907	5766	5603	5603
q19	1304	1286	924	924
q20	512	401	259	259
q21	5827	2658	2299	2299
q22	441	352	302	302
Total cold run time: 101427 ms
Total hot run time: 28656 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4323	4228	4238	4228
q2	q3	4489	4922	4355	4355
q4	2087	2181	1385	1385
q5	4418	4248	4326	4248
q6	228	174	128	128
q7	1727	1649	1975	1649
q8	2627	2224	2153	2153
q9	7906	7906	7856	7856
q10	4789	4743	4336	4336
q11	584	414	377	377
q12	756	780	547	547
q13	3474	3684	2950	2950
q14	329	327	318	318
q15	q16	732	737	642	642
q17	1363	1319	1345	1319
q18	7832	7441	6893	6893
q19	1172	1090	1122	1090
q20	2214	2212	1945	1945
q21	5266	4538	4468	4468
q22	519	469	408	408
Total cold run time: 56835 ms
Total hot run time: 51295 ms

@hello-stephen

hello-stephen commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 169192 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f16e401af2aad0528e843109004f8e82209317a5, data reload: false

query5	4375	647	486	486
query6	447	202	188	188
query7	4898	580	311	311
query8	366	217	202	202
query9	8756	4133	4122	4122
query10	447	313	267	267
query11	5946	2406	2225	2225
query12	160	104	101	101
query13	1269	640	461	461
query14	6579	5432	5062	5062
query14_1	4429	4399	4385	4385
query15	205	200	179	179
query16	1011	459	447	447
query17	1132	726	598	598
query18	2719	495	357	357
query19	219	194	151	151
query20	115	108	107	107
query21	220	139	119	119
query22	13785	13597	13502	13502
query23	17292	16597	16207	16207
query23_1	16306	16350	16361	16350
query24	7744	1782	1307	1307
query24_1	1314	1303	1315	1303
query25	542	439	386	386
query26	1318	331	164	164
query27	2626	550	345	345
query28	4409	2023	1969	1969
query29	1062	607	466	466
query30	307	244	199	199
query31	1125	1088	938	938
query32	103	61	60	60
query33	528	313	254	254
query34	1168	1178	664	664
query35	761	778	678	678
query36	1398	1395	1225	1225
query37	150	107	93	93
query38	3211	3158	3051	3051
query39	923	924	896	896
query39_1	873	884	870	870
query40	223	131	106	106
query41	67	66	63	63
query42	97	94	100	94
query43	319	327	278	278
query44	
query45	203	190	174	174
query46	1095	1228	728	728
query47	2361	2406	2237	2237
query48	390	408	308	308
query49	613	476	362	362
query50	964	354	267	267
query51	4333	4296	4318	4296
query52	89	89	77	77
query53	245	267	192	192
query54	265	221	202	202
query55	83	79	69	69
query56	235	234	209	209
query57	1416	1422	1306	1306
query58	241	212	216	212
query59	1589	1679	1428	1428
query60	292	253	235	235
query61	169	156	166	156
query62	700	665	592	592
query63	241	193	197	193
query64	2613	840	673	673
query65	
query66	1746	491	358	358
query67	28989	29686	29519	29519
query68	
query69	433	322	277	277
query70	995	961	960	960
query71	310	235	214	214
query72	3016	2676	2268	2268
query73	853	737	422	422
query74	5101	4948	4813	4813
query75	2643	2582	2258	2258
query76	2310	1183	785	785
query77	359	394	293	293
query78	12371	12496	11916	11916
query79	2323	1121	757	757
query80	1345	474	438	438
query81	527	282	240	240
query82	607	154	120	120
query83	319	276	254	254
query84	
query85	922	530	429	429
query86	436	299	286	286
query87	3390	3343	3180	3180
query88	3635	2762	2737	2737
query89	425	396	329	329
query90	1905	186	177	177
query91	177	163	139	139
query92	65	63	57	57
query93	1743	1402	851	851
query94	714	356	312	312
query95	675	483	350	350
query96	1105	798	360	360
query97	2724	2703	2564	2564
query98	210	208	202	202
query99	1153	1173	1044	1044
Total cold run time: 252917 ms
Total hot run time: 169192 ms

@hello-stephen

hello-stephen commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 95.83% (23/24) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.89% (21142/39230)
Line Coverage 37.60% (201318/535416)
Region Coverage 33.65% (157953/469420)
Branch Coverage 34.68% (69144/199366)

@hello-stephen

hello-stephen commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (24/24) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.86% (28300/38318)
Line Coverage 57.83% (307829/532305)
Region Coverage 54.52% (257120/471602)
Branch Coverage 55.95% (111700/199635)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hubgeter @hello-stephen