[fix](snapshot) drop index should set db_id (#58401)#62770
[fix](snapshot) drop index should set db_id (#58401)#62770yiguolei merged 1 commit intoapache:branch-4.1from
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
No blocking issues found.
Critical checkpoints:
- Correctness: Pass. The patch consistently threads through the FE call chain that reaches cloud , including table erase, rollup/schema-change cancel, MV/rollup drop, restore, recycle-bin cleanup, and replay.
- Completeness: Pass. I did not find remaining FE-side callers of , , , or in this branch that still omit .
- Compatibility: Pass for the touched paths. The replay/recycle metadata used here already carries (, ), so the new argument is available where this PR consumes it.
- Tests: No new automated coverage was added in this PR. Existing cloud/meta-service tests already exercise with , but FE-side propagation still relies on code inspection rather than a dedicated regression test.
User focus:
- No additional user-provided review focus was supplied.
Residual risk:
- I did not run FE unit tests in this review session.
There was a problem hiding this comment.
No blocking issues found.
Critical checkpoints:
- Correctness: Pass. The patch consistently threads dbId through the FE call chain that reaches cloud drop_index, including table erase, rollup/schema-change cancel, MV/rollup drop, restore, recycle-bin cleanup, and replay.
- Completeness: Pass. I did not find remaining FE-side callers of onEraseOlapTable, eraseTableDropBackendReplicas, eraseDroppedIndex, or dropMaterializedIndex in this branch that still omit dbId.
- Compatibility: Pass for the touched paths. The replay/recycle metadata used here already carries dbId (DropInfo, RecycleTableInfo), so the new argument is available where this PR consumes it.
- Tests: No new automated coverage was added in this PR. Existing cloud/meta-service tests already exercise drop_index with db_id, but FE-side propagation still relies on code inspection rather than a dedicated regression test.
User focus:
- No additional user-provided review focus was supplied.
Residual risk:
- I did not run FE unit tests in this review session.
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
49251b5 to
d5f347e
Compare
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
cherry-pick #58401
recycle_indexes require db_id to recycle multi versioned keys, but drop index does not set db_id