Skip to content

[chore](field) Rename Tuple to Struct in the field. #57466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[chore](field) Rename Tuple to Struct in the field. #57466

wants to merge 1 commit into from

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Oct 29, 2025

What problem does this PR solve?

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Oct 29, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 29, 2025

ClickBench: Total hot run time: 27.67 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2fd22d9eeb44f74a74567acb3067ec078c1a9e40, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.06
query3	0.26	0.08	0.09
query4	1.61	0.12	0.12
query5	0.27	0.26	0.24
query6	1.19	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.63	0.52	0.52
query10	0.59	0.59	0.58
query11	0.17	0.12	0.12
query12	0.16	0.16	0.11
query13	0.62	0.61	0.61
query14	1.00	1.03	1.00
query15	0.87	0.84	0.87
query16	0.39	0.40	0.39
query17	1.04	1.03	1.07
query18	0.22	0.19	0.20
query19	1.90	1.85	1.83
query20	0.02	0.01	0.01
query21	15.44	0.18	0.14
query22	5.12	0.06	0.05
query23	15.64	0.26	0.11
query24	2.86	0.89	0.39
query25	0.08	0.06	0.07
query26	0.14	0.13	0.13
query27	0.06	0.06	0.05
query28	4.57	1.16	0.96
query29	12.56	3.95	3.33
query30	0.29	0.14	0.13
query31	2.83	0.60	0.38
query32	3.24	0.55	0.47
query33	3.01	3.07	3.00
query34	15.93	5.13	4.53
query35	4.56	4.59	4.57
query36	0.67	0.51	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.15
query41	0.08	0.03	0.04
query42	0.04	0.04	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.72 s
Total hot run time: 27.67 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

BE UT Coverage Report

Increment line coverage 75.00% (6/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.76% (18065/34243)
Line Coverage 37.99% (163809/431224)
Region Coverage 32.38% (124933/385848)
Branch Coverage 33.72% (54602/161929)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.27% (24246/33548)
Line Coverage 59.11% (254784/431036)
Region Coverage 55.08% (215156/390610)
Branch Coverage 56.42% (91795/162712)

@Mryange
Copy link
Contributor Author

Mryange commented Oct 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

ClickBench: Total hot run time: 27.56 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2fd22d9eeb44f74a74567acb3067ec078c1a9e40, data reload: false

query1	0.06	0.05	0.05
query2	0.08	0.06	0.06
query3	0.26	0.08	0.08
query4	1.61	0.11	0.12
query5	0.27	0.26	0.25
query6	1.18	0.66	0.63
query7	0.03	0.02	0.03
query8	0.06	0.04	0.05
query9	0.63	0.53	0.52
query10	0.59	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.63	0.60
query14	1.01	1.01	1.01
query15	0.87	0.84	0.86
query16	0.41	0.40	0.40
query17	1.05	1.03	1.08
query18	0.22	0.20	0.20
query19	1.88	1.82	1.83
query20	0.01	0.01	0.01
query21	15.80	0.19	0.13
query22	5.61	0.07	0.04
query23	15.67	0.26	0.11
query24	3.06	1.35	0.39
query25	0.09	0.06	0.06
query26	0.14	0.13	0.14
query27	0.08	0.06	0.05
query28	4.34	1.17	0.94
query29	12.56	3.97	3.31
query30	0.29	0.14	0.12
query31	2.82	0.59	0.38
query32	3.23	0.55	0.46
query33	3.03	3.07	3.06
query34	15.74	5.16	4.49
query35	4.61	4.55	4.56
query36	0.66	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.13
query41	0.09	0.04	0.04
query42	0.04	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.44 s
Total hot run time: 27.56 s

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

BE UT Coverage Report

Increment line coverage 75.00% (6/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.75% (18067/34250)
Line Coverage 37.99% (163854/431352)
Region Coverage 32.35% (124916/386180)
Branch Coverage 33.72% (54621/161991)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.31% (24314/33624)
Line Coverage 59.10% (255135/431691)
Region Coverage 54.98% (215231/391460)
Branch Coverage 56.35% (91831/162976)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.32% (24316/33624)
Line Coverage 59.11% (255163/431691)
Region Coverage 55.01% (215323/391460)
Branch Coverage 56.36% (91854/162976)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.32% (24316/33624)
Line Coverage 59.11% (255163/431691)
Region Coverage 55.01% (215323/391460)
Branch Coverage 56.36% (91854/162976)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.43% (24017/33624)
Line Coverage 57.81% (249566/431691)
Region Coverage 52.94% (207243/391460)
Branch Coverage 54.65% (89070/162976)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mryange @hello-stephen @doris-robot