-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](arrow-flight-sql) Support arrow-flight-sql
protocol getStreamCatalogs
, getStreamSchemas
, getStreamTables
#46217
Merged
xinyiZzz
merged 4 commits into
apache:master
from
xinyiZzz:20241224_fix_arrow_flight_gettable
Jan 2, 2025
Merged
[opt](arrow-flight-sql) Support arrow-flight-sql
protocol getStreamCatalogs
, getStreamSchemas
, getStreamTables
#46217
xinyiZzz
merged 4 commits into
apache:master
from
xinyiZzz:20241224_fix_arrow_flight_gettable
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32639 ms
|
TPC-DS: Total hot run time: 189818 ms
|
ClickBench: Total hot run time: 31.67 s
|
yiguolei
approved these changes
Jan 2, 2025
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Indicates a PR has been approved by one committer.
reviewed
labels
Jan 2, 2025
PR approved by anyone and no changes requested. |
wangbo
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…mCatalogs`, `getStreamSchemas`, `getStreamTables` (#46217) ### What problem does this PR solve? Implement the `getStreamCatalogs`, `getStreamSchemas`, `getStreamTables` methods in the arrow-flight-sql protocol, which can support BI tools to correctly display the metadata tree when using the `arrow-flight-sql` Driver to connect to Doris. DBeaver uses the `arrow-flight-sql` Driver connecting to Doris: 1. list all catalogs and show properties ![image](https://github.com/user-attachments/assets/f1de6e87-ba5d-4d67-a7bb-06fd91b6cbb1) 2. list dbSchemas and show properties ![image](https://github.com/user-attachments/assets/e706a065-420a-4137-a6a1-6e4f807fad8a) 3. list tables and list table columns. ![image](https://github.com/user-attachments/assets/f9929da9-8cc3-4d74-9f73-b3837854c349) 4. external catalog ![image](https://github.com/user-attachments/assets/ef9ebee1-36d8-4f7f-b97a-e4720ed45d1c) ![image](https://github.com/user-attachments/assets/58f1e0d9-17ed-48a9-be89-dfb818672525) How to connect to Doris: (will be organized into documents later) https://www.dremio.com/blog/jdbc-driver-for-arrow-flight-sql/#h-how-to-use-jdbc-driver-with-dbeaver-client https://docs.dremio.com/current/sonar/client-applications/clients/dbeaver/?_gl=1*1epgwh0*_gcl_au*MjUyNjE1ODM0LjE3MzQwMDExNDg.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…mCatalogs`, `getStreamSchemas`, `getStreamTables` (#46217) ### What problem does this PR solve? Implement the `getStreamCatalogs`, `getStreamSchemas`, `getStreamTables` methods in the arrow-flight-sql protocol, which can support BI tools to correctly display the metadata tree when using the `arrow-flight-sql` Driver to connect to Doris. DBeaver uses the `arrow-flight-sql` Driver connecting to Doris: 1. list all catalogs and show properties ![image](https://github.com/user-attachments/assets/f1de6e87-ba5d-4d67-a7bb-06fd91b6cbb1) 2. list dbSchemas and show properties ![image](https://github.com/user-attachments/assets/e706a065-420a-4137-a6a1-6e4f807fad8a) 3. list tables and list table columns. ![image](https://github.com/user-attachments/assets/f9929da9-8cc3-4d74-9f73-b3837854c349) 4. external catalog ![image](https://github.com/user-attachments/assets/ef9ebee1-36d8-4f7f-b97a-e4720ed45d1c) ![image](https://github.com/user-attachments/assets/58f1e0d9-17ed-48a9-be89-dfb818672525) How to connect to Doris: (will be organized into documents later) https://www.dremio.com/blog/jdbc-driver-for-arrow-flight-sql/#h-how-to-use-jdbc-driver-with-dbeaver-client https://docs.dremio.com/current/sonar/client-applications/clients/dbeaver/?_gl=1*1epgwh0*_gcl_au*MjUyNjE1ODM0LjE3MzQwMDExNDg.
yiguolei
pushed a commit
that referenced
this pull request
Jan 2, 2025
…ol `getStreamCatalogs`, `getStreamSchemas`, `getStreamTables` #46217 (#46268) Cherry-picked from #46217 Co-authored-by: Xinyi Zou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement the
getStreamCatalogs
,getStreamSchemas
,getStreamTables
methods in the arrow-flight-sql protocol, which can support BI tools to correctly display the metadata tree when using thearrow-flight-sql
Driver to connect to Doris.DBeaver uses the
arrow-flight-sql
Driver connecting to Doris:How to connect to Doris: (will be organized into documents later)
https://www.dremio.com/blog/jdbc-driver-for-arrow-flight-sql/#h-how-to-use-jdbc-driver-with-dbeaver-client
https://docs.dremio.com/current/sonar/client-applications/clients/dbeaver/?_gl=1*1epgwh0*_gcl_au*MjUyNjE1ODM0LjE3MzQwMDExNDg.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)