[Bug](exec) fix setSinkOp null flag bug

apache · Jun 24, 2024 · b5f9e79 · b5f9e79
1 parent d7dc33a
commit b5f9e79
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/be/src/pipeline/exec/set_sink_operator.cpp b/be/src/pipeline/exec/set_sink_operator.cpp
@@ -171,6 +171,8 @@ Status SetSinkLocalState<is_intersect>::open(RuntimeState* state) {
     SCOPED_TIMER(_open_timer);
     RETURN_IF_ERROR(PipelineXSinkLocalState<SetSharedState>::open(state));
 
+    auto output_data_types = vectorized::VectorizedUtils::get_data_types(
+            _parent->cast<SetSinkOperatorX<is_intersect>>()._row_descriptor);
     auto& parent = _parent->cast<Parent>();
     DCHECK(parent._cur_child_id == 0);
     auto& child_exprs_lists = _shared_state->child_exprs_lists;
@@ -180,7 +182,9 @@ Status SetSinkLocalState<is_intersect>::open(RuntimeState* state) {
     for (const auto& ctl : child_exprs_lists) {
         for (int i = 0; i < ctl.size(); ++i) {
             _shared_state->build_not_ignore_null[i] =
-                    _shared_state->build_not_ignore_null[i] || ctl[i]->root()->is_nullable();
+                (output_data_types[i] ||
+                _shared_state->build_not_ignore_null[i] ||
+                ctl[i]->root()->is_nullable());
         }
     }
     _shared_state->hash_table_init();

diff --git a/be/src/pipeline/exec/set_sink_operator.h b/be/src/pipeline/exec/set_sink_operator.h
@@ -77,7 +77,8 @@ class SetSinkOperatorX final : public DataSinkOperatorX<SetSinkLocalState<is_int
               _is_colocate(is_intersect ? tnode.intersect_node.is_colocate
                                         : tnode.except_node.is_colocate),
               _partition_exprs(is_intersect ? tnode.intersect_node.result_expr_lists[child_id]
-                                            : tnode.except_node.result_expr_lists[child_id]) {}
+                                            : tnode.except_node.result_expr_lists[child_id]),
+              _row_descriptor(descs, tnode.row_tuples, tnode.nullable_tuples) {}
     ~SetSinkOperatorX() override = default;
     Status init(const TDataSink& tsink) override {
         return Status::InternalError("{} should not init with TDataSink",
@@ -113,6 +114,7 @@ class SetSinkOperatorX final : public DataSinkOperatorX<SetSinkLocalState<is_int
     const bool _is_colocate;
     const std::vector<TExpr> _partition_exprs;
     using OperatorBase::_child_x;
+    const RowDescriptor _row_descriptor;
 };
 
 } // namespace pipeline

diff --git a/regression-test/data/correctness_p0/test_set_operation.out b/regression-test/data/correctness_p0/test_set_operation.out
@@ -11,3 +11,7 @@ aaaa
 bbbb
 
 -- !select1 --
+
+-- !select1 --
+3.0
+
diff --git a/regression-test/suites/correctness_p0/test_set_operation.groovy b/regression-test/suites/correctness_p0/test_set_operation.groovy
@@ -127,4 +127,6 @@ suite("test_set_operation") {
 
     qt_select1  """ (select 0) intersect (select null); """
 
+    qt_select1  """ select sqrt('9') except select sqrt('4'); """
+
 }