[Fix-17732] Change workflow instance status to failure when command handle failed #17745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #17732 by ensuring that workflow instance status is set to FAILURE when command handling fails during bootstrap. The changes introduce proper error handling and state management when command processing encounters exceptions, preventing workflow instances from being stuck in intermediate states.
Key Changes:
- Adds workflow instance state update to FAILURE in error handling path
- Makes error command movement transactional to ensure atomicity
- Enhances WorkflowGraph with duplicate task name/code validation
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
CommandEngine.java |
Adds logic to force update workflow instance state to FAILURE when command bootstrap fails, plus enhanced logging |
CommandServiceImpl.java |
Adds @transactional annotation to ensure atomic error command insertion and command deletion |
WorkflowGraph.java |
Replaces stream-based map creation with explicit loop to add duplicate task name/code validation |
WorkflowInstanceDao.java |
Adds interface method for force updating workflow instance state without origin state check |
WorkflowInstanceDaoImpl.java |
Implements force update method delegating to mapper |
WorkflowInstanceMapper.java |
Adds mapper method signature for force state update |
WorkflowInstanceMapper.xml |
Adds SQL update statement that updates state without checking current state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...heduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java
Outdated
Show resolved
Hide resolved
...o/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/WorkflowInstanceDaoImpl.java
Show resolved
Hide resolved
...er/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/CommandEngine.java
Outdated
Show resolved
Hide resolved
...ster/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowGraph.java
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_changeWorkflowInstanceStateToFailure
branch
from
7da42ef to
e248fdd
Compare
ruanwenjun
force-pushed
the
dev_wenjun_changeWorkflowInstanceStateToFailure
branch
from
e248fdd to
6ef9e79
Compare
zhongjiajie
previously approved these changes
Nov 27, 2025
SbloodyS
previously approved these changes
Nov 27, 2025
ruanwenjun
dismissed stale reviews from SbloodyS and zhongjiajie
via
82533fb
ruanwenjun
force-pushed
the
dev_wenjun_changeWorkflowInstanceStateToFailure
branch
from
6ef9e79 to
82533fb
Compare
SbloodyS
previously approved these changes
Nov 28, 2025
ruanwenjun
force-pushed
the
dev_wenjun_changeWorkflowInstanceStateToFailure
branch
from
82533fb to
6f87ceb
Compare
|
ruanwenjun
force-pushed
the
dev_wenjun_changeWorkflowInstanceStateToFailure
branch
3 times, most recently
from
cf58747 to
a5ae49a
Compare
SbloodyS
approved these changes
Nov 30, 2025
ruanwenjun
force-pushed
the
dev_wenjun_changeWorkflowInstanceStateToFailure
branch
from
0022e10 to
88a48b0
Compare
|
zhongjiajie
approved these changes
Dec 2, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #17732
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md