-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-35][Alert] Refactor the alert thread model #15932
[DSIP-35][Alert] Refactor the alert thread model #15932
Conversation
f84b3a2
to
948517b
Compare
...eduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertSender.java
Fixed
Show fixed
Hide fixed
...eduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertSender.java
Fixed
Show fixed
Hide fixed
...lert-server/src/main/java/org/apache/dolphinscheduler/alert/service/ListenerEventSender.java
Fixed
Show fixed
Hide fixed
...lert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventSender.java
Fixed
Show fixed
Hide fixed
...erver/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventPendingQueue.java
Fixed
Show fixed
Hide fixed
...erver/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventPendingQueue.java
Fixed
Show fixed
Hide fixed
...erver/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventPendingQueue.java
Fixed
Show fixed
Hide fixed
...lert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventSender.java
Fixed
Show fixed
Hide fixed
...ain/java/org/apache/dolphinscheduler/registry/api/ha/AbstractServerStatusChangeListener.java
Fixed
Show fixed
Hide fixed
...registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ha/AbstractHAServer.java
Fixed
Show fixed
Hide fixed
4016e97
to
51654cf
Compare
...eduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertSender.java
Fixed
Show fixed
Hide fixed
0028796
to
fb54c8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15932 +/- ##
============================================
- Coverage 39.95% 39.93% -0.03%
- Complexity 5061 5080 +19
============================================
Files 1355 1369 +14
Lines 45562 45634 +72
Branches 4885 4869 -16
============================================
+ Hits 18206 18222 +16
- Misses 25453 25514 +61
+ Partials 1903 1898 -5 ☔ View full report in Codecov by Sentry. |
a6836ee
to
cd2fd6e
Compare
8f6a459
to
a0e5210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM.
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/dolphinscheduler/registry/api/ha/AbstractServerStatusChangeListener.java
Outdated
Show resolved
Hide resolved
...t-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertEventPendingQueue.java
Show resolved
Hide resolved
e2d7b6d
to
4119a6b
Compare
...registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ha/AbstractHAServer.java
Outdated
Show resolved
Hide resolved
1666693
to
d841a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there any way we can retrigger the action? I have created an issue to |
d841a14
to
de22b33
Compare
Close/Reopen to retrigger the checker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Purpose of the pull request
close #15931
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md