[DSIP-35][Alert] Refactor the alert thread model #15932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
from
f84b3a2
to
948517b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...eduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertSender.java
Fixed
Show fixed
Hide fixed
...eduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertSender.java
Fixed
Show fixed
Hide fixed
...lert-server/src/main/java/org/apache/dolphinscheduler/alert/service/ListenerEventSender.java
Fixed
Show fixed
Hide fixed
...lert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventSender.java
Fixed
Show fixed
Hide fixed
...erver/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventPendingQueue.java
Fixed
Show fixed
Hide fixed
...erver/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventPendingQueue.java
Fixed
Show fixed
Hide fixed
...erver/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventPendingQueue.java
Fixed
Show fixed
Hide fixed
...lert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AbstractEventSender.java
Fixed
Show fixed
Hide fixed
...ain/java/org/apache/dolphinscheduler/registry/api/ha/AbstractServerStatusChangeListener.java
Fixed
Show fixed
Hide fixed
...registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ha/AbstractHAServer.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
4 times, most recently
from
4016e97
to
51654cf
Compare
...eduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertSender.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
2 times, most recently
from
0028796
to
fb54c8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15932 +/- ##
============================================
- Coverage 39.95% 39.93% -0.03%
- Complexity 5061 5080 +19
============================================
Files 1355 1369 +14
Lines 45562 45634 +72
Branches 4885 4869 -16
============================================
+ Hits 18206 18222 +16
- Misses 25453 25514 +61
+ Partials 1903 1898 -5 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
2 times, most recently
from
a6836ee
to
cd2fd6e
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
4 times, most recently
from
8f6a459
to
a0e5210
Compare
Radeity
reviewed
May 5, 2024
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/dolphinscheduler/registry/api/ha/AbstractServerStatusChangeListener.java
Outdated
Show resolved
Hide resolved
...t-server/src/main/java/org/apache/dolphinscheduler/alert/service/AlertEventPendingQueue.java
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
2 times, most recently
from
e2d7b6d
to
4119a6b
Compare
Radeity
reviewed
May 6, 2024
...registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ha/AbstractHAServer.java
Outdated
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
from
1666693
to
d841a14
Compare
It's odd. I can't trigger the re-execution either. It seems to be out of order... |
|
Is there any way we can retrigger the action? I have created an issue to |
ruanwenjun
force-pushed
the
dev_wenjun_fixAlertSendModel
branch
from
d841a14
to
de22b33
Compare
|
Close/Reopen to retrigger the checker. |
|
We may need to remove this bot, otherwise we need to wait recovery. |
Agreed. Remove it for now. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #15931
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md