Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feture 5752]Add blocking task type #715

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgsky1
Copy link
Contributor

@mgsky1 mgsky1 commented Mar 6, 2022

This PR contains Blocking task description writen in chinese and english.

You can refer: PR #6272 and Issue #5752 in DS main repo for more infomation about blocking task.

@mgsky1
Copy link
Contributor Author

mgsky1 commented Mar 6, 2022

There are no images, because the front-end side has not been writen.😂 I just write a demo page for testing and not make a pull request.

@mgsky1 mgsky1 changed the title Add blocking task type [Feture 5752]Add blocking task type Mar 6, 2022
@caishunfeng
Copy link
Contributor

There are no images, because the front-end side has not been writen.joy I just write a demo page for testing and not make a pull request.

Hi @mgsky1 I think you should add the front-end side together to keep the complete feature.
BTW, DS will use the Next UI for upgrading, so you should develop in the Next UI for new feature.

@zhongjiajie
Copy link
Member

@songjianet Do we have a plan to add this type task

@zhongjiajie zhongjiajie added the waiting user response Waiting PR submiter response label Mar 7, 2022
@mgsky1
Copy link
Contributor Author

mgsky1 commented Mar 7, 2022

@songjianet Do we have a plan to add this type task

This is a Summer 2021 project. I completed the backend code, now turn to the front-end.

@songjianet
Copy link
Member

For the old UI, this work will not be supported, but it can be implemented in the new UI, but due to scheduling reasons, we may not support it in a short period of time, if you can handle the front end If so, you can handle it yourself, but it is still unknown when this feature will be officially released.

@zhongjiajie
Copy link
Member

I got it, maybe we should merge task docs without screenshots and UI this time

@zhongjiajie
Copy link
Member

@Tianqi-Dotes Could you please take a look in this English version docs?

@zhongjiajie zhongjiajie added waiting for review Waiting review from reviewer and removed waiting user response Waiting PR submiter response labels Mar 9, 2022
@caishunfeng
Copy link
Contributor

I got it, maybe we should merge task docs without screenshots and UI this time

I don't think so, users can't use blocking task types due to lack of UI, so why wait for UI to be ready and then add this document?

@zhongjiajie zhongjiajie added missing-ui and removed waiting for review Waiting review from reviewer labels Mar 10, 2022
@zhongjiajie
Copy link
Member

I change my mind and waiting for ui, I add the label missing-ui on this PR, waiting for UI. Thank @caishunfeng

@zhongjiajie
Copy link
Member

Hi @mgsky1 since we migrate our docs into apache/dolphinscheduler in PR apache/dolphinscheduler#9291, you should change this file in https://github.com/apache/dolphinscheduler/tree/dev/docs instead of apache/dolphinscheduler-website. Do you have time to migrate it to apache/dolphinscheduler? If you need some help, feel free to ping me.

@mgsky1
Copy link
Contributor Author

mgsky1 commented May 12, 2022

Hi @mgsky1 since we migrate our docs into apache/dolphinscheduler in PR apache/dolphinscheduler#9291, you should change this file in https://github.com/apache/dolphinscheduler/tree/dev/docs instead of apache/dolphinscheduler-website. Do you have time to migrate it to apache/dolphinscheduler? If you need some help, feel free to ping me.

Sorry for replying this comment so late. I am busy with graduating. I would like to know if this project is urgent. If not, I can finish this task.

@zhongjiajie
Copy link
Member

Looking forward about the change, currently you should change the document in path https://github.com/apache/dolphinscheduler/tree/dev/docs/docs instead of repo website , because to already migrate our doc to apache/dolphinscheduler now

@mgsky1
Copy link
Contributor Author

mgsky1 commented May 14, 2022

Looking forward about the change, currently you should change the document in path https://github.com/apache/dolphinscheduler/tree/dev/docs/docs instead of repo website , because to already migrate our doc to apache/dolphinscheduler now

Got it ~

@mgsky1
Copy link
Contributor Author

mgsky1 commented Jun 11, 2022

The UI and doc development has been completed. PR#10397
@zhongjiajie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants