[Bug] Fix download error (#968)

apache · Oct 23, 2024 · 3ce7b14 · 3ce7b14
1 parent fb7bd1e
commit 3ce7b14
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 23 deletions.
diff --git a/public/index.html b/public/index.html
@@ -13,7 +13,6 @@
       name="keywords"
       content="apache dolphinscheduler,dolphinscheduler,document,community,workflow scheduler,data orchestration,workflow orchestration,drag and drop workflow,DAG"
     />
-    <link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
     <!--
       manifest.json provides metadata used when your web app is installed on a
       user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/

diff --git a/public/manifest.json b/public/manifest.json
@@ -6,16 +6,6 @@
       "src": "favicon.ico",
       "sizes": "64x64 32x32 24x24 16x16",
       "type": "image/x-icon"
-    },
-    {
-      "src": "logo192.png",
-      "type": "image/png",
-      "sizes": "192x192"
-    },
-    {
-      "src": "logo512.png",
-      "type": "image/png",
-      "sizes": "512x512"
     }
   ],
   "start_url": ".",

diff --git a/src/components/NavBar/index.jsx b/src/components/NavBar/index.jsx
@@ -143,16 +143,6 @@ const NavBar = () => {
           >
             <Button shape="round">{t("contacts")}</Button>
           </Dropdown>
-          <Button
-            type="primary"
-            shape="round"
-            onClick={() => {
-              navigate(`/${locale}/download`);
-              setSelectedKeys("");
-            }}
-          >
-            {t("download")}
-          </Button>
         </Space>
       </section>
     </nav>

diff --git a/src/hooks/useVersions.js b/src/hooks/useVersions.js
@@ -2,13 +2,23 @@ import { useEffect, useState } from "react";
 import getVersions from "../api/getVersions";
 
 export const useVersions = () => {
+  const reverseVersions = (versions) => {
+    let reversedVersions = versions.reverse();
+    const devIndex = reversedVersions.indexOf("dev");
+    if (devIndex > -1) {
+      reversedVersions.splice(devIndex, 1);
+      reversedVersions.push("dev");
+    }
+    return reversedVersions;
+  };
+
   const stored = JSON.parse(sessionStorage.getItem("versions")) || [];
-  const [versions, setVersions] = useState(stored.reverse());
+  const [versions, setVersions] = useState(reverseVersions(stored));
 
   useEffect(() => {
     if (!stored.length) {
       getVersions().then((result) => {
-        setVersions(result.reverse());
+        setVersions(reverseVersions(result));
       });
     }
     // eslint-disable-next-line

diff --git a/src/views/Documentation/index.jsx b/src/views/Documentation/index.jsx
@@ -42,11 +42,15 @@ const Documentation = () => {
     handleAnchor,
     navigate,
   } = useDocumentation(params);
+  let downloadButtonIsDisabled = false;
   const searchRef = useRef();
 
   if (!versions.includes(params.version)) {
     return <Navigate to={`/${locale}/docs/${versions[0]}`} replace={true} />;
   }
+  if (params.version === "dev") {
+    downloadButtonIsDisabled = true;
+  }
   return (
     <section className="documentation" id="documentation">
       <div className="documentation-sider">
@@ -69,6 +73,7 @@ const Documentation = () => {
           shape="round"
           ghost
           size="large"
+          disabled={downloadButtonIsDisabled}
           onClick={() => {
             navigate(`/${locale}/download/${params.version}`);
           }}