Skip to content

refactor: clean up aggregation planning - #25104

Open
2010YOUY01 wants to merge 1 commit into
apache:mainfrom
2010YOUY01:cleanup-aggr-planning
Open

refactor: clean up aggregation planning#25104
2010YOUY01 wants to merge 1 commit into
apache:mainfrom
2010YOUY01:cleanup-aggr-planning

Conversation

@2010YOUY01

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

See issue

What changes are included in this PR?

What is the testing strategy for this PR?

Existing tests.

Are there any user-facing changes?

No.

required_input_ordering: Option<OrderingRequirements>,
/// Describes how the input is ordered relative to the group by columns
///
/// This field is also overloaded to mean "the output MUST preserve this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an existing assumption, and I feel it's slightly confusing.

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Sep 9, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.80%. Comparing base (4048898) to head (d717c45).

Files with missing lines Patch % Lines
datafusion/physical-plan/src/aggregates/mod.rs 56.52% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25104      +/-   ##
==========================================
- Coverage   81.80%   81.80%   -0.01%     
==========================================
  Files        1130     1130              
  Lines      417754   417701      -53     
  Branches   417754   417701      -53     
==========================================
- Hits       341754   341698      -56     
+ Misses      55875    55874       -1     
- Partials    20125    20129       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup aggregation planning

2 participants