refactor: clean up aggregation planning - #25104
Open
2010YOUY01 wants to merge 1 commit into
Open
Conversation
2010YOUY01
commented
Sep 9, 2026
| required_input_ordering: Option<OrderingRequirements>, | ||
| /// Describes how the input is ordered relative to the group by columns | ||
| /// | ||
| /// This field is also overloaded to mean "the output MUST preserve this |
Contributor
Author
There was a problem hiding this comment.
This is an existing assumption, and I feel it's slightly confusing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25104 +/- ##
==========================================
- Coverage 81.80% 81.80% -0.01%
==========================================
Files 1130 1130
Lines 417754 417701 -53
Branches 417754 417701 -53
==========================================
- Hits 341754 341698 -56
+ Misses 55875 55874 -1
- Partials 20125 20129 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See issue
What changes are included in this PR?
What is the testing strategy for this PR?
Existing tests.
Are there any user-facing changes?
No.