Skip to content

minor: make MinIO tests more stable - #25092

Merged
alamb merged 2 commits into
apache:mainfrom
comphead:chore_ci_dfcli
Sep 10, 2026
Merged

minor: make MinIO tests more stable#25092
alamb merged 2 commits into
apache:mainfrom
comphead:chore_ci_dfcli

Conversation

@comphead

@comphead comphead commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

I observed PRs sometimes got kicked out of merge queue because flaky datafusion-cli tests, which require full CI again

The datafusion-cli storage integration tests (test_cli, test_aws_options, test_s3_url_fallback, test_object_store_profiling) each start their own MinIO container, so a single CI run pulls the image several times concurrently. Any transient Docker failure during that pull fails the test immediately:

thread 'test_aws_options' panicked at datafusion-cli/tests/cli_integration.rs:607:25:
called `Result::unwrap()` on an `Err` value: "Failed to start MinIO container.
Ensure Docker is running and accessible: failed to pull the image
'minio/minio:RELEASE.2025-02-28T09-55-16Z', error: bytes remaining on stream"

These errors are transient and clear on a second attempt, so a flaky pull should not fail the job.

Rationale for this change

The datafusion-cli storage integration tests (test_cli, test_aws_options, test_s3_url_fallback, test_object_store_profiling) each start their own MinIO container, so a single CI run pulls the image several times concurrently. Any transient Docker failure during that pull fails the test immediately:

thread 'test_aws_options' panicked at datafusion-cli/tests/cli_integration.rs:607:25:
called `Result::unwrap()` on an `Err` value: "Failed to start MinIO container.
Ensure Docker is running and accessible: failed to pull the image
'minio/minio:RELEASE.2025-02-28T09-55-16Z', error: bytes remaining on stream"

These errors are transient and clear on a second attempt, so a flaky pull should not fail the job.

@comphead
comphead requested a review from Jefffrey September 9, 2026 00:08
@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Sep 9, 2026
@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.90%. Comparing base (4f0faac) to head (7c29026).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25092      +/-   ##
==========================================
- Coverage   81.91%   81.90%   -0.01%     
==========================================
  Files        1132     1132              
  Lines      420570   420570              
  Branches   420570   420570              
==========================================
- Hits       344490   344480      -10     
- Misses      55765    55770       +5     
- Partials    20315    20320       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me -- thanks @comphead

@alamb
alamb added this pull request to the merge queue Sep 10, 2026
Merged via the queue into apache:main with commit 1ec9ede Sep 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants