Skip to content

fix: scope HashJoinExec build_time to hash-table construction only #24271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulrichurriola-parada-ops wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: scope HashJoinExec build_time to hash-table construction only #24271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions datafusion/physical-plan/src/joins/hash_join/exec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2249,6 +2249,10 @@ async fn collect_left_input(
memory_counter: _,
} = state;

// Only time hash-table construction, not the `try_fold` above (that's the
// child's own compute).
let _build_timer = metrics.build_time.timer();

// Compute bounds
let mut bounds = match bounds_accumulators {
Some(accumulators) if num_rows > 0 => {
Expand Down
2 changes: 0 additions & 2 deletions datafusion/physical-plan/src/joins/hash_join/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,15 +660,13 @@ impl HashJoinStream {
&mut self,
cx: &mut std::task::Context<'_>,
) -> Poll<Result<StatefulStreamResult<Option<RecordBatch>>>> {
let build_timer = self.join_metrics.build_time.timer();
// build hash table from left (build) side, if not yet done
let left_data = ready!(
self.build_side
.try_as_initial_mut()?
.left_fut
.get_shared(cx)
)?;
build_timer.done();

// Note: For null-aware anti join, we need to check the probe side (right) for NULLs,
// not the build side (left). The probe-side NULL check happens during process_probe_batch.
Expand Down