refactor(hash-aggr): Disable the legacy aggregation implementation. - #24263
Draft
2010YOUY01 wants to merge 5 commits into
Draft
refactor(hash-aggr): Disable the legacy aggregation implementation.#242632010YOUY01 wants to merge 5 commits into
2010YOUY01 wants to merge 5 commits into
Conversation
2010YOUY01
marked this pull request as draft
August 11, 2026 10:36
14 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24263 +/- ##
==========================================
- Coverage 81.06% 80.99% -0.07%
==========================================
Files 1107 1108 +1
Lines 382191 384708 +2517
Branches 382191 384708 +2517
==========================================
+ Hits 309805 311612 +1807
- Misses 54083 54725 +642
- Partials 18303 18371 +68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #22710
Depends on #24262
Only the last commit belongs to this PR. I’ll rebase onto main after the dependent PR is merged.
Rationale for this change
This PR intends to be the last PR for functionally complete #22710, it logically disable the legacy implementation and fully move to the new refactor.
The legacy implementation is not deleted yet, so if anything goes wrong, we can use the config to revert to the old implementation
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?