Skip to content

refactor(hash-aggr): Disable the legacy aggregation implementation. - #24263

Draft
2010YOUY01 wants to merge 5 commits into
apache:mainfrom
2010YOUY01:split-aggr-05-disable-legacy
Draft

refactor(hash-aggr): Disable the legacy aggregation implementation.#24263
2010YOUY01 wants to merge 5 commits into
apache:mainfrom
2010YOUY01:split-aggr-05-disable-legacy

Conversation

@2010YOUY01

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #22710
Depends on #24262

Only the last commit belongs to this PR. I’ll rebase onto main after the dependent PR is merged.

Rationale for this change

This PR intends to be the last PR for functionally complete #22710, it logically disable the legacy implementation and fully move to the new refactor.

The legacy implementation is not deleted yet, so if anything goes wrong, we can use the config to revert to the old implementation

set datafusion.execution.enable_migration_aggregate = false;

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@2010YOUY01
2010YOUY01 marked this pull request as draft August 11, 2026 10:36
@github-actions github-actions Bot added documentation Improvements or additions to documentation core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) common Related to common crate physical-plan Changes to the physical-plan crate labels Aug 11, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.21971% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.99%. Comparing base (634f0b3) to head (942a35e).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...sical-plan/src/aggregates/ordered_single_stream.rs 86.74% 49 Missing and 10 partials ⚠️
datafusion/physical-plan/src/aggregates/mod.rs 84.97% 11 Missing and 15 partials ⚠️
...sical-plan/src/aggregates/partial_reduce_stream.rs 57.14% 13 Missing and 2 partials ⚠️
...plan/src/aggregates/aggregate_hash_table/common.rs 88.37% 0 Missing and 5 partials ⚠️
.../aggregates/aggregate_hash_table/common_ordered.rs 60.00% 0 Missing and 2 partials ⚠️
...gates/aggregate_hash_table/ordered_single_table.rs 94.44% 0 Missing and 2 partials ⚠️
...c/aggregates/aggregate_hash_table/partial_table.rs 0.00% 0 Missing and 1 partial ⚠️
...rc/aggregates/aggregate_hash_table/single_table.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24263      +/-   ##
==========================================
- Coverage   81.06%   80.99%   -0.07%     
==========================================
  Files        1107     1108       +1     
  Lines      382191   384708    +2517     
  Branches   382191   384708    +2517     
==========================================
+ Hits       309805   311612    +1807     
- Misses      54083    54725     +642     
- Partials    18303    18371      +68     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate documentation Improvements or additions to documentation physical-plan Changes to the physical-plan crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants