fix: Propagate NULLs in regexp_count, regexp_instr - #24239
Open
neilconway wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24239 +/- ##
==========================================
+ Coverage 80.98% 81.00% +0.01%
==========================================
Files 1106 1106
Lines 383495 383697 +202
Branches 383495 383697 +202
==========================================
+ Hits 310590 310810 +220
+ Misses 54572 54551 -21
- Partials 18333 18336 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
regexp_count,regexp_instr#24152Rationale for this change
regexp_countandregexp_instrshould follow the behavior of these functions in PostgreSQL and return NULL when any of their arguments is NULL. The previous behavior was inconsistent:regexp_instrreturned NULL for a NULL string or pattern, but otherwise NULLs were treated as a default value, returned a match count of 0, or raised an error, depending on the context.What changes are included in this PR?
regexp_countandregexp_instrconsistent and match PostgreSQLAre these changes tested?
Yes, new tests added and/or existing tests updated when necessary.
Are there any user-facing changes?
Yes: the behavior of these UDFs has changed when called with NULL arguments.