feat: add ASOF joins to DataFrame API - #23831
Merged
Merged
Conversation
github-actions
Bot
added
sql
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23831 +/- ##
==========================================
+ Coverage 81.80% 81.90% +0.10%
==========================================
Files 1130 1132 +2
Lines 417754 420600 +2846
Branches 417754 420600 +2846
==========================================
+ Hits 341754 344503 +2749
+ Misses 55875 55773 -102
- Partials 20125 20324 +199 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Xuanwo
force-pushed
the
xuanwo/asof-dataframe
branch
from
August 20, 2026 17:56
90448bd to
7713821
Compare
Xuanwo
force-pushed
the
xuanwo/asof-dataframe
branch
from
August 28, 2026 05:40
7713821 to
7ef360b
Compare
github-actions
Bot
removed
physical-expr
# Conflicts: # datafusion/expr/src/logical_plan/builder.rs # datafusion/expr/src/logical_plan/plan.rs # datafusion/substrait/tests/cases/serialize.rs
Xuanwo
marked this pull request as ready for review
September 9, 2026 12:18
Member
Author
|
@2010YOUY01 & @jayzhan211, this PR is ready, let's go! |
jayzhan211
approved these changes
Sep 10, 2026
jayzhan211
left a comment
jayzhan211
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Xuanwo , some non-blocking suggestions
github-actions
Bot
removed
sql
github-actions
Bot
removed
optimizer
Member
Author
|
Thank you @jayzhan211 and @2010YOUY01, let's rock! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2026
Member
Author
|
Cc @2010YOUY01 for another merge queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is the DataFrame API layer of the ASOF JOIN stack. It exposes the logical contract already available on
mainthrough the fluent API without coupling DataFrame callers to SQL.What changes are included in this PR?
DataFrame::join_asofwith an optional equality expression and one ordered match expression.DataFrame::join_asof_usingfor same-named equality keys.Are these changes tested?
Yes:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion --test core_integration dataframe::join_asof --all-featuresAre there any user-facing changes?
Users can build ASOF joins through
DataFrame::join_asofandDataFrame::join_asof_using. Both methods use the same expression validation and left-preserving semantics as the logical builder and SQL API.