feat: Support BinaryView type in approx_distinct#23333
Merged
Merged
Conversation
mkleen
changed the title
mkleen
force-pushed
the
binary_view_approx_distinct
branch
from
41fe468 to
392c818
Compare
github-actions
Bot
added
sqllogictest
Jefffrey
approved these changes
Jul 7, 2026
Contributor
|
thanks @mkleen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
approx_distinctfunction #22989 but does not close it. More types are coming.Rationale for this change
BinaryViewtype forapprox_distinctBinaryViewcan be directly supported forHLLAccumulatorandHllGroupsAccumulatorWhat changes are included in this PR?
HLLAccumulatorandHllGroupsAccumulatorto supportBinaryViewaggregate.sltAre these changes tested?
Yes
Are there any user-facing changes?
Yes,
approx_distinctsupports nowBinaryViewbut no breaking changes.