perf: Optimize NULL handling in substr#21519
Merged
comphead merged 1 commit intoapache:mainfrom Apr 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
substr#21518.Rationale for this change
Similar to other recent changes,
substrcurrently checks for NULLs and builds the result NULL bitmap on a per-row basis. It is faster to instead compute the result NULL bitmap in bulk via bitwise AND.Benchmarks (ARM64):
What changes are included in this PR?
make_and_append_viewtoappend_view, and have callers deal with NULL handling; making it part ofappend_viewencourages per-row NULL computations, which should be avoided when possible.append_viewas never-inline; this avoids a performance regression on some of thesubstrmicrobenchmarks, where LLVM is a little eager to inline a large-ish function into a hot loop.Are these changes tested?
Yes.
Are there any user-facing changes?
No.