Run core benchmarks with CodSpeed #19594
Draft
+74
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
Tpt
force-pushed
the
tpt/codspeed
branch
3 times, most recently
from
fbbb63f to
e5c00db
Compare
Contributor
|
Are these benchmarks still run in github action nodes? If so I think it'll still suffer with noisy results. |
Contributor
Author
|
@Omega359 Indeed. What Codspeed does is some kind of instrumentation to get stable results. It has the shortcoming of not handling sycalls well: https://codspeed.io/docs/instruments/cpu/overview |
Tpt
force-pushed
the
tpt/codspeed
branch
7 times, most recently
from
bf9f3f9 to
b72834a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Use https://codspeed.io to run benchmarks and track results
What changes are included in this PR?
Run the
corebenchmarks with codspeed