Let FileScanConfig own a list of ProjectionExprs
#18253
Open
+151
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
friendlymatthew
force-pushed
the
friendlymatthew/pushdown-propogation
branch
3 times, most recently
from
01f0446 to
248d1b9
Compare
friendlymatthew
force-pushed
the
friendlymatthew/pushdown-propogation
branch
from
248d1b9 to
9e4344a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TableProviders#14993Rationale for this change
To enable expression pushdown to file sources, we need to plumb expressions through the
FileScanConfiglayer. Currently,FileScanConfigonly tracks column indices for projection, which limits us to simple and naive column selection.This PR begins expression pushdown implementation by having
FileScanConfigown a list ofProjectionExprs, instead of column indices. This allows file sources to eventually receive and optimize based on the actual expressions being projected.Notes about this PR
TableProviders#14993) into 2 tasks:DataSource(FileScanConfig) actually hold projection expressions (this PR)DataSourceExecall the way to theFileSource