Skip to content

Fix contains function expression #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liamzwbao
Copy link

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes, I think this can be simply tested by importing the contains function and making sure it compiles with 2 args.

Are there any user-facing changes?

User can use contains function as expected

@github-actions github-actions bot added the functions Changes to functions implementation label May 14, 2025
@liamzwbao liamzwbao marked this pull request as ready for review May 14, 2025 02:06
Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @liamzwbao!

@jonathanc-n
Copy link
Contributor

cc @jayzhan211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes to functions implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust API - "contains" function expression wrongly declared, not usable
2 participants