Skip to content

Conversation

@LucaCappelletti94
Copy link
Contributor

Added support for ALTER OPERATOR CLASS syntax.

}))
}

pub fn parse_alter_operator_class(&mut self) -> Result<Statement, ParserError> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add documentation for the function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I add the deny missing doc to clippy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the deny missing doc, but there is an impressive amount of missing doc. I am trying to add the missing documentation so to make it impossible for missing documentation in future development.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it was quite an effort but now #![forbid(missing_docs)] is in place and everything public is documented

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LucaCappelletti94!

@iffyio
Copy link
Contributor

iffyio commented Jan 9, 2026

@LucaCappelletti94 could you look to resolve the conflicts on this branch when you have some time?

@LucaCappelletti94
Copy link
Contributor Author

I fixed stuff rapidly in the github editor, so likely there will be some mess. Will fix in a sec.

@iffyio iffyio added this pull request to the merge queue Jan 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2026
@LucaCappelletti94
Copy link
Contributor Author

I have documented the code that had no documentation in the main.

@iffyio iffyio added this pull request to the merge queue Jan 9, 2026
Merged via the queue into apache:main with commit aa5c6b3 Jan 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants