-
Notifications
You must be signed in to change notification settings - Fork 685
Added support for ALTER OPERATOR CLASS syntax
#2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| })) | ||
| } | ||
|
|
||
| pub fn parse_alter_operator_class(&mut self) -> Result<Statement, ParserError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add documentation for the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I add the deny missing doc to clippy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the deny missing doc, but there is an impressive amount of missing doc. I am trying to add the missing documentation so to make it impossible for missing documentation in future development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it was quite an effort but now #![forbid(missing_docs)] is in place and everything public is documented
iffyio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @LucaCappelletti94!
|
@LucaCappelletti94 could you look to resolve the conflicts on this branch when you have some time? |
|
I fixed stuff rapidly in the github editor, so likely there will be some mess. Will fix in a sec. |
|
I have documented the code that had no documentation in the main. |
Added support for
ALTER OPERATOR CLASSsyntax.