Add support for MySQL MEMBER OF #1917
Merged
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 1, 2025
src/ast/mod.rs
Outdated
| /// <value> MEMBER OF(<array>) | ||
| /// ``` | ||
| /// [MySQL](https://dev.mysql.com/doc/refman/8.4/en/json-search-functions.html#operator_member-of) | ||
| MemberOf(Box<Expr>, Box<Expr>), |
There was a problem hiding this comment.
Can we introduce a struct for the expression e.g. MemberOf(MemberOf{ value, json })? That way it would be less breaking if spans or other options are added to the expression later on
|
|
||
| #[test] | ||
| fn parse_json_member_of() { | ||
| mysql().verified_stmt(r#"SELECT 17 MEMBER OF('[23, "abc", 17, "ab", 10]')"#); |
There was a problem hiding this comment.
For one of the tests can we assert the reurned expr that it contains the expected values in the expected fields in the AST?
src/parser/mod.rs
Outdated
Comment on lines
3614
to
3616
| let _ = self.expect_token(&Token::LParen); | ||
| let expr2 = self.parse_expr()?; | ||
| let _ = self.expect_token(&Token::RParen); |
There was a problem hiding this comment.
It looks like we're dropping potential error returned by the expect_token calls (we should probably add a test case for this behavior)?
There was a problem hiding this comment.
Updated, I'm just a bit rusty :-) ...
yoavcloud
force-pushed
the
mysql_member_of
branch
from
47c3ce1 to
0b74460
Compare
iffyio
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.mysql.com/doc/refman/8.4/en/json-search-functions.html#operator_member-of