Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate LEFT JOIN from LEFT OUTER JOIN #1726

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Differentiate LEFT JOIN from LEFT OUTER JOIN #1726

merged 1 commit into from
Feb 14, 2025

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Feb 14, 2025

And same for RIGHT JOIN.

Although these are generally syntactically equivalent, I believe it is preferable to preserve the original input when rendering.

@mvzink
Differentiate LEFT JOIN from LEFT OUTER JOIN
491ed32 
And same for RIGHT JOIN.

Although these are generally syntactically equivalent, I believe it is preferable to preserve the original input when rendering.
iffyio
iffyio approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!
cc @alamb

@iffyio iffyio merged commit 68c41a9 into apache:main Feb 14, 2025
9 checks passed
@mvzink mvzink deleted the push-wxtrlvmnukwm branch February 14, 2025 16:25
@alamb
Copy link
Contributor

alamb commented Feb 14, 2025 •
edited
Loading

Makes sense -- thanks @mvzink and @iffyio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvzink @alamb @iffyio